diff --git a/typo3/sysext/extbase/Classes/Service/ImageService.php b/typo3/sysext/extbase/Classes/Service/ImageService.php index 4234b5f363701c9676a2e14443d1453274ef2abc..9af53cf73f5558a1fc8765392f6fa7d5ca83f9f7 100644 --- a/typo3/sysext/extbase/Classes/Service/ImageService.php +++ b/typo3/sysext/extbase/Classes/Service/ImageService.php @@ -19,6 +19,7 @@ use TYPO3\CMS\Core\Resource\File; use TYPO3\CMS\Core\Resource\FileInterface; use TYPO3\CMS\Core\Resource\FileReference; use TYPO3\CMS\Core\Resource\ProcessedFile; +use TYPO3\CMS\Core\Resource\ResourceFactory; use TYPO3\CMS\Core\Utility\GeneralUtility; use TYPO3\CMS\Core\Utility\MathUtility; @@ -28,29 +29,25 @@ use TYPO3\CMS\Core\Utility\MathUtility; class ImageService implements \TYPO3\CMS\Core\SingletonInterface { /** - * @var \TYPO3\CMS\Core\Resource\ResourceFactory + * @var ResourceFactory */ protected $resourceFactory; /** - * @var \TYPO3\CMS\Extbase\Service\EnvironmentService + * @var EnvironmentService */ protected $environmentService; /** - * @param \TYPO3\CMS\Core\Resource\ResourceFactory $resourceFactory - */ - public function injectResourceFactory(\TYPO3\CMS\Core\Resource\ResourceFactory $resourceFactory) - { - $this->resourceFactory = $resourceFactory; - } - - /** - * @param \TYPO3\CMS\Extbase\Service\EnvironmentService $environmentService + * ImageService constructor. + * + * @param EnvironmentService|null $environmentService + * @param ResourceFactory|null $resourceFactory */ - public function injectEnvironmentService(\TYPO3\CMS\Extbase\Service\EnvironmentService $environmentService) + public function __construct(EnvironmentService $environmentService = null, ResourceFactory $resourceFactory = null) { - $this->environmentService = $environmentService; + $this->environmentService = $environmentService ?? GeneralUtility::makeInstance(EnvironmentService::class); + $this->resourceFactory = $resourceFactory ?? ResourceFactory::getInstance(); } /** diff --git a/typo3/sysext/extbase/Tests/Unit/Service/ImageScriptServiceTest.php b/typo3/sysext/extbase/Tests/Unit/Service/ImageScriptServiceTest.php index c7e4d96df0557c0b0c9c3661c729cf96bb8da99d..7f983b0166f65f77bb115a6125a4c0c16f2b0bfc 100644 --- a/typo3/sysext/extbase/Tests/Unit/Service/ImageScriptServiceTest.php +++ b/typo3/sysext/extbase/Tests/Unit/Service/ImageScriptServiceTest.php @@ -41,9 +41,8 @@ class ImageScriptServiceTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestC */ protected function setUp() { - $this->subject = new ImageService(); $this->environmentService = $this->createMock(EnvironmentService::class); - $this->inject($this->subject, 'environmentService', $this->environmentService); + $this->subject = new ImageService($this->environmentService); GeneralUtility::flushInternalRuntimeCaches(); $_SERVER['HTTP_HOST'] = 'foo.bar'; }