From be650b8c97b07bca46c8761efc67517a855bbd88 Mon Sep 17 00:00:00 2001
From: Felix Althaus <felix.althaus@undkonsorten.com>
Date: Wed, 30 Oct 2019 19:35:39 +0100
Subject: [PATCH] [BUGFIX] Avoid double escaping of opendocs menu entries
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Menu entries in both open documents and recent documents list
of the opendocs extension were htmlspecialchar‘ed twice. One
level of escaping was removed.
Resolves: #89553
Releases: master
Change-Id: Id04f8742e3b91ad3ce8618f4d49f2d4e12b93d71
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62161
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
---
.../Classes/Backend/ToolbarItems/OpendocsToolbarItem.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php b/typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php
index f0903eb093f8..9547f922ac0e 100644
--- a/typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php
+++ b/typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php
@@ -175,7 +175,7 @@ class OpendocsToolbarItem implements ToolbarItemInterface
$result = [];
$result['table'] = $table;
$result['record'] = $record;
- $result['label'] = htmlspecialchars(strip_tags(htmlspecialchars_decode($document[0])));
+ $result['label'] = strip_tags(htmlspecialchars_decode($document[0]));
/** @var \TYPO3\CMS\Backend\Routing\UriBuilder $uriBuilder */
$uriBuilder = GeneralUtility::makeInstance(UriBuilder::class);
$uri = (string)$uriBuilder->buildUriFromRoute('record_edit') . '&' . $document[2];
--
GitLab