diff --git a/Build/phpstan/phpstan-baseline.neon b/Build/phpstan/phpstan-baseline.neon index e82b9b5ebba4783556b8623da0e4869fdb69cb0e..567c1e1597203cba477afccf01b916af47ac09f9 100644 --- a/Build/phpstan/phpstan-baseline.neon +++ b/Build/phpstan/phpstan-baseline.neon @@ -2705,16 +2705,6 @@ parameters: count: 1 path: ../../typo3/sysext/fluid/Classes/View/TemplatePaths.php - - - message: "#^Else branch is unreachable because previous condition is always true\\.$#" - count: 1 - path: ../../typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php - - - - message: "#^Else branch is unreachable because previous condition is always true\\.$#" - count: 1 - path: ../../typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php - - message: "#^Parameter \\#2 \\$attributeValue of method TYPO3Fluid\\\\Fluid\\\\Core\\\\ViewHelper\\\\TagBuilder\\:\\:addAttribute\\(\\) expects array\\|string\\|Traversable\\|null, TYPO3\\\\CMS\\\\Core\\\\Http\\\\Uri given\\.$#" count: 1 diff --git a/typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php b/typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php index 2be90bda4af0a80f26262ef0735bcf85908ce8d8..3de645353f40ee52d603d26f17687ff3eb5e6cf8 100644 --- a/typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php +++ b/typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php @@ -116,7 +116,7 @@ final class CssViewHelper extends AbstractTagBasedViewHelper $attributes['disabled'] = 'disabled'; } - $file = $this->tag->getAttribute('href'); + $file = $attributes['href'] ?? null; unset($attributes['href']); $options = [ 'priority' => $this->arguments['priority'], diff --git a/typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php b/typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php index 29a02d17500695d3bcfa1a7a826274a74225ce21..30ef679863c8865a9cb245048db546557cc4108d 100644 --- a/typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php +++ b/typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php @@ -112,7 +112,7 @@ final class ScriptViewHelper extends AbstractTagBasedViewHelper } } - $src = $this->tag->getAttribute('src'); + $src = $attributes['src'] ?? null; unset($attributes['src']); $options = [ 'priority' => $this->arguments['priority'],