From b8811cef65b41439cc9d1808546a2fbe412862c3 Mon Sep 17 00:00:00 2001
From: Benni Mack <benni@typo3.org>
Date: Thu, 26 Jul 2018 20:53:54 +0200
Subject: [PATCH] [TASK] Improve usage of Backend RequestHandler
The backend request with the cli check is dead code
since a different application is used for cli.
Resolves: #85662
Releases: master
Change-Id: Icea2667e9369c4041094eaa53283c6c59b3e9dd7
Reviewed-on: https://review.typo3.org/57695
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
---
typo3/sysext/backend/Classes/Http/RequestHandler.php | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/typo3/sysext/backend/Classes/Http/RequestHandler.php b/typo3/sysext/backend/Classes/Http/RequestHandler.php
index d3ce5726fe51..f87743a36da7 100644
--- a/typo3/sysext/backend/Classes/Http/RequestHandler.php
+++ b/typo3/sysext/backend/Classes/Http/RequestHandler.php
@@ -25,8 +25,7 @@ use TYPO3\CMS\Core\Http\Response;
use TYPO3\CMS\Core\Utility\GeneralUtility;
/**
- * General RequestHandler for the TYPO3 Backend. This is used for all Backend requests except for CLI
- * or AJAX calls.
+ * General RequestHandler for the TYPO3 Backend. This is used for all Backend requests, including AJAX routes.
*
* If a get/post parameter "route" is set, the Backend Routing is called and searches for a
* matching route inside the Router. The corresponding controller / action is called then which returns the response.
@@ -79,14 +78,14 @@ class RequestHandler implements RequestHandlerInterface, PsrRequestHandlerInterf
}
/**
- * This request handler can handle any backend request (but not CLI).
+ * This request handler can handle any backend request.
*
* @param ServerRequestInterface $request
- * @return bool If the request is not a CLI script, TRUE otherwise FALSE
+ * @return bool If the request is BE request TRUE otherwise FALSE
*/
public function canHandleRequest(ServerRequestInterface $request): bool
{
- return TYPO3_REQUESTTYPE & TYPO3_REQUESTTYPE_BE && !(TYPO3_REQUESTTYPE & TYPO3_REQUESTTYPE_CLI);
+ return (bool)(TYPO3_REQUESTTYPE & TYPO3_REQUESTTYPE_BE);
}
/**
--
GitLab