From b78bfb044c2c91d0ca336382f0fe711727f3ceae Mon Sep 17 00:00:00 2001
From: Benni Mack <benni@typo3.org>
Date: Fri, 13 Jan 2023 11:53:09 +0100
Subject: [PATCH] [BUGFIX] Remove hack for UriBuilder in conjunction with
$GLOBALS[LANG]
Because FormProtectionFactory now uses proper injection, this
hack is not needed anymore.
Resolves: #99532
Related: #98696
Releases: main
Change-Id: Id743944586511352228f6187815b70561593f1a0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77374
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
---
.../backend/Classes/Middleware/BackendUserAuthenticator.php | 3 ---
1 file changed, 3 deletions(-)
diff --git a/typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php b/typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php
index 2530cb9780a1..b22f6617ff1f 100644
--- a/typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php
+++ b/typo3/sysext/backend/Classes/Middleware/BackendUserAuthenticator.php
@@ -203,9 +203,6 @@ class BackendUserAuthenticator extends \TYPO3\CMS\Core\Middleware\BackendUserAut
ServerRequestInterface $request,
array $parameters = []
): ResponseInterface {
- // GLOBALS[LANG] needs to be set up, because the UriBuilder is generating a token, which in turn
- // needs the FormProtectionFactory, which then builds a Message Closure with GLOBALS[LANG] (hacky, yes!)
- $GLOBALS['LANG'] = $this->languageServiceFactory->createFromUserPreferences($user);
$response = new RedirectResponse(
GeneralUtility::makeInstance(UriBuilder::class)->buildUriWithRedirect($endpoint, $parameters, RouteRedirect::createFromRequest($request))
);
--
GitLab