From ad8fd1a158335630da0521be94f07dcc789288e5 Mon Sep 17 00:00:00 2001
From: Helmut Hummel <typo3@helhum.io>
Date: Mon, 27 Mar 2017 20:01:04 +0200
Subject: [PATCH] [BUGFIX] Do not allow dots in ratio IDs
Due to usage of Fluid dynamic variable parts in the template,
ratio IDs must not contain a "."
Resolves: #80214
Releases: master
Change-Id: I12dac926169c827c9e3022320dd90a058f72913b
Reviewed-on: https://review.typo3.org/52194
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
---
typo3/sysext/core/Classes/Imaging/ImageManipulation/Ratio.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/typo3/sysext/core/Classes/Imaging/ImageManipulation/Ratio.php b/typo3/sysext/core/Classes/Imaging/ImageManipulation/Ratio.php
index d8301cd5d229..45e05a291f50 100644
--- a/typo3/sysext/core/Classes/Imaging/ImageManipulation/Ratio.php
+++ b/typo3/sysext/core/Classes/Imaging/ImageManipulation/Ratio.php
@@ -32,7 +32,7 @@ class Ratio
public function __construct(string $id, string $title, float $value)
{
- $this->id = $id;
+ $this->id = str_replace('.', '_', $id);
$this->title = $title;
$this->value = $value;
}
--
GitLab