From aa3511d609167beee33e2614ae1388dea55be80a Mon Sep 17 00:00:00 2001
From: Nicole Cordes <typo3@cordes.co>
Date: Sun, 17 Nov 2013 01:22:16 +0100
Subject: [PATCH] [BUGFIX] Improve output for "deprecated RTE properties"
updater
When running the update wizard for "Deprecated RTE properties in Page
TSconfig" the output contains html tags which are htmlspecialchared.
Furthermore the output of the custom messages is corrected to show the
information when available.
Resolves: #53710
Releases: 6.2
Change-Id: Ia488d0fd0368c318617bb245a0f9fcd25099506b
Reviewed-on: https://review.typo3.org/25472
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
---
.../Classes/Hook/Install/DeprecatedRteProperties.php | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/typo3/sysext/rtehtmlarea/Classes/Hook/Install/DeprecatedRteProperties.php b/typo3/sysext/rtehtmlarea/Classes/Hook/Install/DeprecatedRteProperties.php
index b0f998657527..cef3e3d020e0 100644
--- a/typo3/sysext/rtehtmlarea/Classes/Hook/Install/DeprecatedRteProperties.php
+++ b/typo3/sysext/rtehtmlarea/Classes/Hook/Install/DeprecatedRteProperties.php
@@ -160,17 +160,17 @@ class DeprecatedRteProperties extends \TYPO3\CMS\Install\Updates\AbstractUpdate
if (count($updateablePages)) {
$this->updatePages($updateablePages, $dbQueries, $customMessages);
} else {
- $customMessages = '<p>Some deprecated Page TSconfig properties were found. However, the wizard was unable to automatically replace any of the deprecated properties found. They will have to be replaced manually.</p>' . LF;
+ $customMessages = 'Some deprecated Page TSconfig properties were found. However, the wizard was unable to automatically replace any of the deprecated properties found. They will have to be replaced manually.' . LF . LF;
$success = TRUE;
}
} else {
- $customMessages = '<p>No deprecated Page TSconfig properties were found on page records.</p>' . LF;
+ $customMessages = '>No deprecated Page TSconfig properties were found on page records.' . LF . LF;
$success = TRUE;
}
- $customMessages .= '<p>Only page records were searched for deprecated properties. However, such properties can also be used in BE group and BE user records (prepended with page.). These are not searched nor updated by this wizard.</p>' . LF . '<p>Page TSconfig may also be included from external files. These were not updated by this wizard. If required, the update will need to be done manually.</p>';
+ $customMessages .= 'Only page records were searched for deprecated properties. However, such properties can also be used in BE group and BE user records (prepended with page.). These are not searched nor updated by this wizard.' . LF . LF . 'Page TSconfig may also be included from external files. These were not updated by this wizard. If required, the update will need to be done manually.';
}
$this->markWizardAsDone();
- return empty($customMessages) || $success;
+ return empty($customMessages) ? $success : FALSE;
}
/**
--
GitLab