From a97089d66572615817344221feb7e5d694aba891 Mon Sep 17 00:00:00 2001
From: Christoph Lehmann <christoph.lehmann@networkteam.com>
Date: Thu, 24 Nov 2022 23:14:07 +0100
Subject: [PATCH] [TASK] AdminPanel: Group sql queries made by PageRepository
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
With this the list of grouped sql queries is
much shorter and better understandable.
Resolves: #99187
Releases: main,11.5
Change-Id: Id78568bbe987d8047860f32d58c79644436671d1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76815
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Christoph Lehmann <christoph.lehmann@networkteam.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Susanne Moog <look@susi.dev>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Susanne Moog <look@susi.dev>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
---
.../sysext/core/Classes/Domain/Repository/PageRepository.php | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/typo3/sysext/core/Classes/Domain/Repository/PageRepository.php b/typo3/sysext/core/Classes/Domain/Repository/PageRepository.php
index 521ad1fb3779..28cc979926ad 100644
--- a/typo3/sysext/core/Classes/Domain/Repository/PageRepository.php
+++ b/typo3/sysext/core/Classes/Domain/Repository/PageRepository.php
@@ -295,7 +295,7 @@ class PageRepository implements LoggerAwareInterface
$queryBuilder->select('*')
->from('pages')
->where(
- $queryBuilder->expr()->eq('uid', (int)$uid),
+ $queryBuilder->expr()->eq('uid', $queryBuilder->createNamedParameter((int)$uid, Connection::PARAM_INT)),
QueryHelper::stripLogicalOperatorPrefix($this->where_hid_del)
);
@@ -346,7 +346,7 @@ class PageRepository implements LoggerAwareInterface
->add(GeneralUtility::makeInstance(DeletedRestriction::class));
$row = $queryBuilder->select('*')
->from('pages')
- ->where($queryBuilder->expr()->eq('uid', (int)$uid))
+ ->where($queryBuilder->expr()->eq('uid', $queryBuilder->createNamedParameter((int)$uid, Connection::PARAM_INT)))
->executeQuery()
->fetchAssociative();
--
GitLab