From a5ecd79ca49ce64e33bb0cc92c822daece4e0b99 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sascha=20L=C3=B6ffler?= <lsascha@gmail.com>
Date: Sat, 17 Mar 2018 15:12:32 +0100
Subject: [PATCH] [TASK] Make CommandLineBackendTest notice free
Resolves: #84435
Releases: master
Change-Id: I031a41c5b22f3d30b0fe0bf55e0ed85f7fa05b7b
Reviewed-on: https://review.typo3.org/56309
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
---
typo3/sysext/core/Classes/Utility/CommandUtility.php | 2 +-
.../Tests/Unit/Backend/CommandLineBackendTest.php | 9 +++------
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/typo3/sysext/core/Classes/Utility/CommandUtility.php b/typo3/sysext/core/Classes/Utility/CommandUtility.php
index a1a894cd6435..731ede0cf655 100644
--- a/typo3/sysext/core/Classes/Utility/CommandUtility.php
+++ b/typo3/sysext/core/Classes/Utility/CommandUtility.php
@@ -159,7 +159,7 @@ class CommandUtility
return -1;
}
// Already checked and valid
- if (self::$applications[$cmd]['valid']) {
+ if (self::$applications[$cmd]['valid'] ?? false) {
return true;
}
// Is set but was (above) not TRUE
diff --git a/typo3/sysext/rsaauth/Tests/Unit/Backend/CommandLineBackendTest.php b/typo3/sysext/rsaauth/Tests/Unit/Backend/CommandLineBackendTest.php
index e1bad6f90a41..0101a0e188d1 100644
--- a/typo3/sysext/rsaauth/Tests/Unit/Backend/CommandLineBackendTest.php
+++ b/typo3/sysext/rsaauth/Tests/Unit/Backend/CommandLineBackendTest.php
@@ -1,4 +1,5 @@
<?php
+declare(strict_types = 1);
namespace TYPO3\CMS\Rsaauth\Tests\Unit\Backend;
/*
@@ -15,17 +16,13 @@ namespace TYPO3\CMS\Rsaauth\Tests\Unit\Backend;
*/
use TYPO3\CMS\Rsaauth\Backend\CommandLineBackend;
+use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
/**
* Test case.
*/
-class CommandLineBackendTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
+class CommandLineBackendTest extends UnitTestCase
{
- /**
- * Subject is not notice free, disable E_NOTICES
- */
- protected static $suppressNotices = true;
-
/**
* @var CommandLineBackend
*/
--
GitLab