From a2647b1aed48d9d82056cd405540fad639feb7e2 Mon Sep 17 00:00:00 2001
From: Markus Klein <markus.klein@typo3.org>
Date: Tue, 20 Jun 2017 20:33:35 +0200
Subject: [PATCH] [BUGFIX] Make sure correct data types are passed around in
 RefIndex
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Releases: master, 8.7
Resolves: #81637
Change-Id: I8b5a1e701b91657efd341aae96a23f4c4d643b43
Reviewed-on: https://review.typo3.org/53293
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Johannes Fürnhammer <j.fuernhammer@siwa.at>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
---
 .../core/Classes/Database/ReferenceIndex.php  | 81 ++++++++++++-------
 1 file changed, 51 insertions(+), 30 deletions(-)

diff --git a/typo3/sysext/core/Classes/Database/ReferenceIndex.php b/typo3/sysext/core/Classes/Database/ReferenceIndex.php
index b6d441d8abd0..6f115ef4a5c7 100644
--- a/typo3/sysext/core/Classes/Database/ReferenceIndex.php
+++ b/typo3/sysext/core/Classes/Database/ReferenceIndex.php
@@ -190,7 +190,6 @@ class ReferenceIndex
      */
     public function updateRefIndexTable($tableName, $uid, $testOnly = false)
     {
-
         // First, secure that the index table is not updated with workspace tainted relations:
         $this->WSOL = false;
 
@@ -201,6 +200,11 @@ class ReferenceIndex
             'addedNodes' => 0
         ];
 
+        $uid = $uid ? (int)$uid : 0;
+        if (!$uid) {
+            return $result;
+        }
+
         // If this table cannot contain relations, skip it
         if ($this->shouldExcludeTableFromReferenceIndex($tableName)) {
             return $result;
@@ -299,7 +303,7 @@ class ReferenceIndex
      *
      * @param string $tableName Table name from $GLOBALS['TCA']
      * @param int $uid Record UID
-     * @return array|NULL Index Rows
+     * @return array|null Index Rows
      */
     public function generateRefIndexData($tableName, $uid)
     {
@@ -309,8 +313,12 @@ class ReferenceIndex
 
         $this->relations = [];
 
-        // Get raw record from DB
-        $record = $this->getRecordRawCached($tableName, $uid);
+        $record = null;
+        $uid = $uid ? (int)$uid : 0;
+        if ($uid) {
+            // Get raw record from DB
+            $record = $this->getRecordRawCached($tableName, $uid);
+        }
 
         if (!is_array($record)) {
             return null;
@@ -399,18 +407,22 @@ class ReferenceIndex
      */
     public function createEntryData($table, $uid, $field, $flexPointer, $deleted, $ref_table, $ref_uid, $ref_string = '', $sort = -1, $softref_key = '', $softref_id = '')
     {
+        $uid = $uid ? (int)$uid : 0;
+        if (!$uid) {
+            return null;
+        }
         return $this->createEntryDataUsingRecord(
-            $table,
+            (string)$table,
             $this->getRecordRawCached($table, $uid),
-            $field,
-            $flexPointer,
-            (int)$deleted,
-            $ref_table,
-            $ref_uid,
-            $ref_string,
-            $sort,
-            $softref_key,
-            $softref_id
+            (string)$field,
+            (string)$flexPointer,
+            $deleted ? (int)$deleted : 0,
+            (string)$ref_table,
+            $ref_uid ? (int)$ref_uid : 0,
+            (string)$ref_string,
+            $sort ? (int)$sort : 0,
+            (string)$softref_key,
+            (string)$softref_id
         );
     }
 
@@ -468,13 +480,17 @@ class ReferenceIndex
      */
     public function createEntryData_dbRels($table, $uid, $fieldName, $flexPointer, $deleted, $items)
     {
+        $uid = $uid ? (int)$uid : 0;
+        if (!$uid) {
+            return;
+        }
         $this->createEntryDataForDatabaseRelationsUsingRecord(
-            $table,
+            (string)$table,
             $this->getRecordRawCached($table, $uid),
-            $fieldName,
-            $flexPointer,
-            $deleted,
-            $items
+            (string)$fieldName,
+            (string)$flexPointer,
+            $deleted ? (int)$deleted : 0,
+            (array)$items
         );
     }
 
@@ -507,13 +523,17 @@ class ReferenceIndex
      */
     public function createEntryData_fileRels($table, $uid, $fieldName, $flexPointer, $deleted, $items)
     {
+        $uid = $uid ? (int)$uid : 0;
+        if (!$uid) {
+            return;
+        }
         $this->createEntryDataForFileRelationsUsingRecord(
-            $table,
+            (string)$table,
             $this->getRecordRawCached($table, $uid),
-            $fieldName,
-            $flexPointer,
-            $deleted,
-            $items
+            (string)$fieldName,
+            (string)$flexPointer,
+            $deleted ? (int)$deleted : 0,
+            (array)$items
         );
     }
 
@@ -560,16 +580,17 @@ class ReferenceIndex
      */
     public function createEntryData_softreferences($table, $uid, $fieldName, $flexPointer, $deleted, $keys)
     {
-        if (!is_array($keys)) {
+        $uid = $uid ? (int)$uid : 0;
+        if (!$uid || !is_array($keys)) {
             return;
         }
         $this->createEntryDataForSoftReferencesUsingRecord(
-            $table,
+            (string)$table,
             $this->getRecordRawCached($table, $uid),
-            $fieldName,
-            $flexPointer,
-            $deleted,
-            $keys
+            (string)$fieldName,
+            (string)$flexPointer,
+            $deleted ? (int)$deleted : 0,
+            (array)$keys
         );
     }
 
-- 
GitLab