From 98af8fbb7e365ddd3594935c0f18a33abcd4883f Mon Sep 17 00:00:00 2001
From: Christian Kuhn <lolli@schwarzbu.ch>
Date: Mon, 15 Nov 2021 13:23:23 +0100
Subject: [PATCH] [TASK] Activate a unit test with PHP 8.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
There was a skipped unit test due to a PHP 8.1 bug.
Latest rc6 fixed the issue, the test can be activated
again.
Resolves: #95976
Related: #95501
Releases: master
Change-Id: Ib5cebf9edd544ca1aa3b91474c6032bf5721176e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72174
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Jochen <rothjochen@gmail.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Jochen <rothjochen@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
---
.../sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php | 8 --------
1 file changed, 8 deletions(-)
diff --git a/typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php b/typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php
index 2b92b396c47e..8cf303e84cc3 100644
--- a/typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php
+++ b/typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php
@@ -461,14 +461,6 @@ class GeneralUtilityTest extends UnitTestCase
*/
public function cmpFqdnReturnsTrue($baseHost, $list): void
{
- // There is a php8.1 bug on alpine which do not resolves the host for ::1 correctly after executing
- // php methods. As first workaround disable only that dataset for php8.1.
- // @see https://bugs.php.net/bug.php?id=81441
- // @see https://github.com/docker-library/php/issues/1201
- // @todo remove this if php8.1/alpine bug for gethostbyaddr(::1) is fixed or otherwise mitigated.
- if ($baseHost === '::1' && PHP_VERSION_ID >= 80100) {
- self::markTestSkipped('Broken with php 8.1 alpine based images. Skipped for now.');
- }
self::assertTrue(GeneralUtility::cmpFQDN($baseHost, $list));
}
--
GitLab