From 97152189455c5aa47c87142542df73745b0271e9 Mon Sep 17 00:00:00 2001
From: Josef Glatz <jousch@gmail.com>
Date: Fri, 31 Jul 2015 08:44:24 +0200
Subject: [PATCH] [TASK] Improve styling of Element Information popup
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Add some space next to the avatar.
Change-Id: I5dbdd6f57ebe19cc21d19230518bdbe42de827a3
Releases: master
Resolves: #68660
Reviewed-on: https://review.typo3.org/42156
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
---
.../Public/Less/TYPO3/_element_table.less | 2 +-
.../ElementInformationController.php | 18 ++++++++++++------
.../t3skin/Resources/Public/Css/backend.css | 2 +-
3 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/Build/Resources/Public/Less/TYPO3/_element_table.less b/Build/Resources/Public/Less/TYPO3/_element_table.less
index 0facac699ef8..ec3256ab61c4 100644
--- a/Build/Resources/Public/Less/TYPO3/_element_table.less
+++ b/Build/Resources/Public/Less/TYPO3/_element_table.less
@@ -114,7 +114,7 @@ table {
.col-nowrap,
.col-control,
.col-clipboard {
- white-space: nowrap;
+ white-space: nowrap!important;
}
.col-control,
.col-clipboard {
diff --git a/typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php b/typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php
index 74be181ea879..69067f8f8880 100644
--- a/typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php
+++ b/typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php
@@ -396,16 +396,22 @@ class ElementInformationController
/** @var Avatar $avatar */
$avatar = GeneralUtility::makeInstance(Avatar::class);
$icon = $avatar->render($creatorRecord);
-
- $rowValue = '<span class="pull-left">' . $icon . '</span>' .
- '<strong>' . htmlspecialchars($GLOBALS['BE_USER']->user['username']) . '</strong><br />'
- . ($GLOBALS['BE_USER']->user['realName'] ? htmlspecialchars($GLOBALS['BE_USER']->user['realName']) : '');
+ $rowValue = '
+ <div class="media">
+ <div class="media-left">
+ ' . $icon . '
+ </div>
+ <div class="media-body">
+ <strong>' . htmlspecialchars($GLOBALS['BE_USER']->user['username']) . '</strong><br>
+ ' . ($GLOBALS['BE_USER']->user['realName'] ? htmlspecialchars($GLOBALS['BE_USER']->user['realName']) : '') . '
+ </div>
+ </div>';
}
}
$tableRows[] = '
<tr>
- <th>' . rtrim($fieldLabel, ':') . '</th>
+ <th class="col-nowrap">' . rtrim($fieldLabel, ':') . '</th>
<td>' . ($name === 'cruser_id' ? $rowValue : htmlspecialchars($rowValue)) . '</td>
</tr>';
}
@@ -434,7 +440,7 @@ class ElementInformationController
$itemLabel = $lang->sL(BackendUtility::getItemLabel($this->table, $name), true);
$tableRows[] = '
<tr>
- <th>' . $itemLabel . '</th>
+ <th class="col-nowrap">' . $itemLabel . '</th>
<td>' . htmlspecialchars($itemValue) . '</td>
</tr>';
}
diff --git a/typo3/sysext/t3skin/Resources/Public/Css/backend.css b/typo3/sysext/t3skin/Resources/Public/Css/backend.css
index b9b4663e94f1..6cc6b421f987 100644
--- a/typo3/sysext/t3skin/Resources/Public/Css/backend.css
+++ b/typo3/sysext/t3skin/Resources/Public/Css/backend.css
@@ -10702,7 +10702,7 @@ fieldset[disabled] .table .btn-default.active {
.table .col-nowrap,
.table .col-control,
.table .col-clipboard {
- white-space: nowrap;
+ white-space: nowrap!important;
}
.table .col-control,
.table .col-clipboard {
--
GitLab