From 95205e5ae2a941ba316686fde736bf4d721d58be Mon Sep 17 00:00:00 2001 From: Sascha Egerer <sascha@sascha-egerer.de> Date: Sun, 19 Feb 2017 20:42:30 +0100 Subject: [PATCH] [BUGFIX] Add missing break statement in switch case There is a break statement missing in a switch case statement. Currently this does not have any side effects but to prevent wrong behavior in the future this should be fixed. Resolves: #79906 Releases: master Change-Id: I2adf40adb1f8df5dcfcdb31f8e9ccddd2b885961 Reviewed-on: https://review.typo3.org/51759 Tested-by: TYPO3com <no-reply@typo3.com> Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by: Thomas Hohn <thomas@hohn.dk> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> --- .../Classes/Form/FormDataProvider/TcaRecordTitle.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php b/typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php index c2bdf411fd76..ff94a90f3168 100644 --- a/typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php +++ b/typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php @@ -158,7 +158,10 @@ class TcaRecordTitle implements FormDataProviderInterface $recordTitle = $this->getRecordTitleForRadioType($rawValue, $fieldConfig); break; case 'inline': - $recordTitle = $this->getRecordTitleForInlineType($rawValue, $result['processedTca']['columns'][$fieldName]['children']); + $recordTitle = $this->getRecordTitleForInlineType( + $rawValue, + $result['processedTca']['columns'][$fieldName]['children'] + ); break; case 'select': $recordTitle = $this->getRecordTitleForSelectType($rawValue, $fieldConfig); @@ -174,6 +177,7 @@ class TcaRecordTitle implements FormDataProviderInterface break; case 'text': $recordTitle = $this->getRecordTitleForTextType($rawValue); + break; case 'flex': // @todo: Check if and how a label could be generated from flex field data default: @@ -207,7 +211,6 @@ class TcaRecordTitle implements FormDataProviderInterface /** * @param int $value * @param array $children - * * @return string */ protected function getRecordTitleForInlineType($value, array $children) -- GitLab