From 94d59bdacfd6cf024bd7b4cdfcc09cd20113f95f Mon Sep 17 00:00:00 2001
From: Benni Mack <benni@typo3.org>
Date: Tue, 10 Sep 2024 21:55:59 +0200
Subject: [PATCH] [BUGFIX] Use proper Doctrine DBAL Statement in sys_note
repository
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Resolves: #104884
Related: #104844
Releases: main
Change-Id: I6361b841eededc837702f9fbe61c236c7502abd0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85994
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Frank Nägler <frank.naegler@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Frank Nägler <frank.naegler@typo3.com>
---
.../Classes/Domain/Repository/SysNoteRepository.php | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/typo3/sysext/sys_note/Classes/Domain/Repository/SysNoteRepository.php b/typo3/sysext/sys_note/Classes/Domain/Repository/SysNoteRepository.php
index 0d2d6f9c9837..23d31b2afd0b 100644
--- a/typo3/sysext/sys_note/Classes/Domain/Repository/SysNoteRepository.php
+++ b/typo3/sysext/sys_note/Classes/Domain/Repository/SysNoteRepository.php
@@ -83,10 +83,6 @@ class SysNoteRepository
/**
* Find notes by given category but restricted to backend user permissions
- *
- * @param int $category Category id
- *
- * @return array
*/
public function findByCategoryRestricted(?int $category = null): array
{
@@ -112,8 +108,10 @@ class SysNoteRepository
);
}
+ $statement = $queryBuilder->executeQuery();
+
$results = [];
- foreach ($queryBuilder->executeQuery()->fetchAllAssociative() as $result) {
+ while ($result = $statement->fetchAssociative()) {
if ($this->checkPermissions($result)) {
$results[] = $result;
}
--
GitLab