From 91a19b03f15bcb57a4ed3839fc1ac7420a40253b Mon Sep 17 00:00:00 2001
From: Jan Helke <typo3@helke.de>
Date: Fri, 16 Mar 2018 12:32:24 +0100
Subject: [PATCH] [TASK] Make IfAuthenticatedViewHelperTest notice free
Releases: master
Resolves: #84340
Change-Id: I97b586423513ab7d2dde4660ccfecf542468ab50
Reviewed-on: https://review.typo3.org/56215
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
---
.../Be/Security/IfAuthenticatedViewHelperTest.php | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/typo3/sysext/fluid/Tests/Unit/ViewHelpers/Be/Security/IfAuthenticatedViewHelperTest.php b/typo3/sysext/fluid/Tests/Unit/ViewHelpers/Be/Security/IfAuthenticatedViewHelperTest.php
index eb0060b14d37..2587a6901546 100644
--- a/typo3/sysext/fluid/Tests/Unit/ViewHelpers/Be/Security/IfAuthenticatedViewHelperTest.php
+++ b/typo3/sysext/fluid/Tests/Unit/ViewHelpers/Be/Security/IfAuthenticatedViewHelperTest.php
@@ -1,4 +1,5 @@
<?php
+declare(strict_types=1);
namespace TYPO3\CMS\Fluid\Tests\Unit\ViewHelpers\Be\Security;
/*
@@ -14,6 +15,7 @@ namespace TYPO3\CMS\Fluid\Tests\Unit\ViewHelpers\Be\Security;
* The TYPO3 project - inspiring people to share!
*/
+use TYPO3\CMS\Fluid\ViewHelpers\Be\Security\IfAuthenticatedViewHelper;
use TYPO3\TestingFramework\Fluid\Unit\ViewHelpers\ViewHelperBaseTestcase;
/**
@@ -22,12 +24,7 @@ use TYPO3\TestingFramework\Fluid\Unit\ViewHelpers\ViewHelperBaseTestcase;
class IfAuthenticatedViewHelperTest extends ViewHelperBaseTestcase
{
/**
- * Subject is not notice free, disable E_NOTICES
- */
- protected static $suppressNotices = true;
-
- /**
- * @var \TYPO3\CMS\Fluid\ViewHelpers\Be\Security\IfAuthenticatedViewHelper
+ * @var IfAuthenticatedViewHelper
*/
protected $viewHelper;
@@ -35,7 +32,7 @@ class IfAuthenticatedViewHelperTest extends ViewHelperBaseTestcase
{
parent::setUp();
$GLOBALS['BE_USER'] = new \stdClass();
- $this->viewHelper = $this->getAccessibleMock(\TYPO3\CMS\Fluid\ViewHelpers\Be\Security\IfAuthenticatedViewHelper::class, ['renderThenChild', 'renderElseChild']);
+ $this->viewHelper = $this->getAccessibleMock(IfAuthenticatedViewHelper::class, ['renderThenChild', 'renderElseChild']);
$this->viewHelper->expects($this->any())->method('renderThenChild')->will($this->returnValue('then child'));
$this->viewHelper->expects($this->any())->method('renderElseChild')->will($this->returnValue('else child'));
$this->injectDependenciesIntoViewHelper($this->viewHelper);
@@ -57,6 +54,7 @@ class IfAuthenticatedViewHelperTest extends ViewHelperBaseTestcase
*/
public function viewHelperRendersElseChildIfBeUserIsNotLoggedIn()
{
+ $GLOBALS['BE_USER']->user = ['uid' => 0];
$actualResult = $this->viewHelper->render();
$this->assertEquals('else child', $actualResult);
}
--
GitLab