From 8fad63d4726a205148ce9aa275f635071e5b1269 Mon Sep 17 00:00:00 2001
From: Morton Jonuschat <m.jonuschat@mojocode.de>
Date: Fri, 24 Feb 2017 23:02:00 -0800
Subject: [PATCH] [BUGFIX] Remove indeterministic test
ensureCorrectPostOrderingByCategoryTitle
The test only works on MySQL with disabled SQL MODE ONLY_FULL_GROUP_BY.
All standard conformant database setups fail this test as the result of
the query is not deterministic due to GROUP BY being evaluated before
ORDER BY.
Change-Id: Ib6d4599e0f5682e8b72971d0f35ef00cfa8d3e6a
Resolves: #80014
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51844
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Johannes Goslar <jogo@kronberger-spiele.de>
Tested-by: Johannes Goslar <jogo@kronberger-spiele.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
---
.../Functional/Persistence/RelationTest.php | 39 -------------------
1 file changed, 39 deletions(-)
diff --git a/typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php b/typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php
index 6f8f0850425e..16bc0da4772e 100644
--- a/typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php
+++ b/typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php
@@ -1010,43 +1010,4 @@ class RelationTest extends \TYPO3\TestingFramework\Core\Functional\FunctionalTes
$blogRepository->update($this->blog);
$this->persistentManager->persistAll();
}
-
- public function ensureCorrectPostOrderingByCategoryTitleDataProvider()
- {
- return [
- 'Post with no category and post with category' => [
- [2, 3],
- [3, 2]
- ],
- 'Posts with category and Post with category and bogus category' => [
- [2, 1],
- [1, 2]
- ],
- 'Posts bogus category and post with category' => [
- [5, 2],
- [5, 2]
- ],
- ];
- }
-
- /**
- * This test covers the case when data is ordered by criteria that is MM related with matchFields involved
- * on the relation table. (post <-> sys_category_mm <-> sys_category)
- *
- * @test
- * @dataProvider ensureCorrectPostOrderingByCategoryTitleDataProvider
- * @group mysql
- */
- public function ensureCorrectPostOrderingByCategoryTitle(array $uids, array $expected)
- {
- /** @var \ExtbaseTeam\BlogExample\Domain\Repository\PostRepository $postRepository */
- $postRepository = $this->objectManager->get(\ExtbaseTeam\BlogExample\Domain\Repository\PostRepository::class);
- $posts = $postRepository->findAllSortedByCategory($uids)->toArray();
- $result = [];
- /** @var Post $post */
- foreach ($posts as $post) {
- $result[] = $post->getUid();
- }
- $this->assertSame($expected, $result);
- }
}
--
GitLab