From 85bb087e4f158cb2e8f029c24c35fe3a2efad53d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jasmina=20Lie=C3=9Fmann?= <minapokhalo+typo3@gmail.com>
Date: Wed, 18 Jan 2023 12:05:26 +0100
Subject: [PATCH] [TASK] Improve Page TSconfig submodule naming
Add headline and a descriptive text to overview of Page TSconfig on
page zero. Update labels in table header too.
Resolves: #99597
Releases: main
Change-Id: Ifd80e361ffc1817818d1489a433886023d1982ca
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77467
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
---
.../Private/Language/InfoPageTsConfig.xlf | 26 ++++++++++++-------
.../Partials/PageTsConfig/PageZero.html | 14 +++++++---
2 files changed, 27 insertions(+), 13 deletions(-)
diff --git a/typo3/sysext/info/Resources/Private/Language/InfoPageTsConfig.xlf b/typo3/sysext/info/Resources/Private/Language/InfoPageTsConfig.xlf
index e4a5db0d84f2..6b9975ae69a9 100644
--- a/typo3/sysext/info/Resources/Private/Language/InfoPageTsConfig.xlf
+++ b/typo3/sysext/info/Resources/Private/Language/InfoPageTsConfig.xlf
@@ -27,21 +27,27 @@
<trans-unit id="sort_alphabetic" resname="sort_alphabetic">
<source>Sort alphabetically</source>
</trans-unit>
- <trans-unit id="pagetitle" resname="pagetitle">
- <source>Pagetitle:</source>
- </trans-unit>
- <trans-unit id="included_tsconfig_files" resname="included_tsconfig_files">
- <source>Included Files:</source>
- </trans-unit>
- <trans-unit id="written_tsconfig_lines" resname="written_tsconfig_lines">
- <source>Lines:</source>
- </trans-unit>
<trans-unit id="tsconf_noPageTSconfig" resname="tsconf_noPageTSconfig">
<source>There are no pages containing custom Page TSconfig settings in the page configuration.</source>
</trans-unit>
- <trans-unit id="tsconf_noPageTSconfigAvailable" resname="tsconf_noPageTSconfig">
+ <trans-unit id="tsconf_noPageTSconfigAvailable" resname="tsconf_noPageTSconfigAvailable">
<source>No suitable Page TSconfig available.</source>
</trans-unit>
+ <trans-unit id="pageTsconfig.overview.description" resname="pageTsconfig.overview.description">
+ <source>Global overview of all pages in the database containing custom Page TSconfig.</source>
+ </trans-unit>
+ <trans-unit id="pageTsconfig.overview.headline" resname="pageTsconfig.overview.headline">
+ <source>Page TSconfig Overview</source>
+ </trans-unit>
+ <trans-unit id="pageTsconfig.overview.table.th.included_tsconfig_files" resname="included_tsconfig_files">
+ <source>Included Files</source>
+ </trans-unit>
+ <trans-unit id="pageTsconfig.overview.table.th.lines" resname="written_tsconfig_lines">
+ <source>Lines</source>
+ </trans-unit>
+ <trans-unit id="pageTsconfig.overview.table.th.pagename" resname="pageTsconfig.overview.table.th.pagename">
+ <source>Page name</source>
+ </trans-unit>
</body>
</file>
</xliff>
diff --git a/typo3/sysext/info/Resources/Private/Partials/PageTsConfig/PageZero.html b/typo3/sysext/info/Resources/Private/Partials/PageTsConfig/PageZero.html
index 66a65522f205..453924d9b918 100644
--- a/typo3/sysext/info/Resources/Private/Partials/PageTsConfig/PageZero.html
+++ b/typo3/sysext/info/Resources/Private/Partials/PageTsConfig/PageZero.html
@@ -3,15 +3,23 @@
data-namespace-typo3-fluid="true"
>
+<f:comment><!-- Heading --></f:comment>
+<h1>
+ <f:translate key="LLL:EXT:info/Resources/Private/Language/InfoPageTsConfig.xlf:pageTsconfig.overview.headline" />
+</h1>
+<div>
+ <p class="lead"><f:translate key="LLL:EXT:info/Resources/Private/Language/InfoPageTsConfig.xlf:pageTsconfig.overview.description" /></p>
+</div>
+
<f:if condition="{overviewOfPagesUsingTSConfig}">
<f:then>
<div class="table-fit">
<table class="table table-striped table-hover">
<thead>
<tr>
- <th>{f:translate(key: 'LLL:EXT:info/Resources/Private/Language/InfoPageTsConfig.xlf:pagetitle')}</th>
- <th>{f:translate(key: 'LLL:EXT:info/Resources/Private/Language/InfoPageTsConfig.xlf:included_tsconfig_files')}</th>
- <th>{f:translate(key: 'LLL:EXT:info/Resources/Private/Language/InfoPageTsConfig.xlf:written_tsconfig_lines')}</th>
+ <th>{f:translate(key: 'LLL:EXT:info/Resources/Private/Language/InfoPageTsConfig.xlf:pageTsconfig.overview.table.th.pagename')}</th>
+ <th>{f:translate(key: 'LLL:EXT:info/Resources/Private/Language/InfoPageTsConfig.xlf:pageTsconfig.overview.table.th.included_tsconfig_files')}</th>
+ <th>{f:translate(key: 'LLL:EXT:info/Resources/Private/Language/InfoPageTsConfig.xlf:pageTsconfig.overview.table.th.lines')}</th>
</tr>
</thead>
<tbody>
--
GitLab