From 8013b4b81870f2edaa37d7059668a185a4b7f903 Mon Sep 17 00:00:00 2001
From: Benjamin Kott <benjamin.kott@outlook.com>
Date: Fri, 7 Jul 2023 09:43:14 +0200
Subject: [PATCH] [BUGFIX] Remove pagination arrows from translations files
We are removing the pagination arrows from the translation
files since they needed to be marked with "aria-hidden" to
avoid acessibility issues. This would extend the usage of
markup that should not be placed in translation files in the
first place. To allow integrators to change the apperance we
are now adding css classes that can be used to apply
special styling for the next and previous links.
Resolves: #101283
Releases: main, 12.4
Change-Id: I090da2922dd644e161440e4e5a1e47ef0963d839
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79858
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
---
.../Classes/ViewHelpers/PageBrowsingViewHelper.php | 4 ++--
.../indexed_search/Resources/Private/Language/locallang.xlf | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingViewHelper.php b/typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingViewHelper.php
index 2f8d53662978..4b5db481f2a9 100644
--- a/typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingViewHelper.php
+++ b/typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingViewHelper.php
@@ -78,7 +78,7 @@ final class PageBrowsingViewHelper extends AbstractTagBasedViewHelper
// show on all pages after the 1st one
if ($currentPage > 0) {
$label = LocalizationUtility::translate('displayResults.previous', 'IndexedSearch') ?? '';
- $content .= '<li>' . $this->makecurrentPageSelector_link($label, $currentPage - 1, $freeIndexUid) . '</li>';
+ $content .= '<li class="tx-indexedsearch-browselist-prev">' . $this->makecurrentPageSelector_link($label, $currentPage - 1, $freeIndexUid) . '</li>';
}
// Check if $maximumNumberOfResultPages is in range
$maximumNumberOfResultPages = MathUtility::forceIntegerInRange($maximumNumberOfResultPages, 1, $pageCount, 10);
@@ -106,7 +106,7 @@ final class PageBrowsingViewHelper extends AbstractTagBasedViewHelper
// next link
if ($currentPage < $pageCount - 1) {
$label = LocalizationUtility::translate('displayResults.next', 'IndexedSearch') ?? '';
- $content .= '<li>' . $this->makecurrentPageSelector_link($label, $currentPage + 1, $freeIndexUid) . '</li>';
+ $content .= '<li class="tx-indexedsearch-browselist-next">' . $this->makecurrentPageSelector_link($label, $currentPage + 1, $freeIndexUid) . '</li>';
}
if (!$this->tag->hasAttribute('class')) {
diff --git a/typo3/sysext/indexed_search/Resources/Private/Language/locallang.xlf b/typo3/sysext/indexed_search/Resources/Private/Language/locallang.xlf
index 41227327046f..bb147ab6c985 100644
--- a/typo3/sysext/indexed_search/Resources/Private/Language/locallang.xlf
+++ b/typo3/sysext/indexed_search/Resources/Private/Language/locallang.xlf
@@ -256,13 +256,13 @@ All search words are converted to lowercase.
</trans-unit>
<trans-unit id="displayResults.previous" resname="displayResults.previous">
- <source>< Previous</source>
+ <source>Previous</source>
</trans-unit>
<trans-unit id="displayResults.page" resname="displayResults.page">
<source>Page</source>
</trans-unit>
<trans-unit id="displayResults.next" resname="displayResults.next">
- <source>Next ></source>
+ <source>Next</source>
</trans-unit>
<trans-unit id="displayResults" resname="displayResults">
<source><![CDATA[Displaying results <strong>%1$s to %2$s</strong> out of <strong>%3$s</strong>]]></source>
--
GitLab