From 7ad894f4b26fdc2a4025782812a36914c132c709 Mon Sep 17 00:00:00 2001
From: Oliver Hader <oliver@typo3.org>
Date: Fri, 1 Jul 2022 15:25:41 +0200
Subject: [PATCH] [BUGFIX] Avoid updating element header in form editor
inspector
When changing values in the form editor inspector, their header
content is updated and overridden - as a result the corresponding
type icon in the header suddenly disappears.
Resolves: #97841
Releases: main, 11.5, 10.4
Change-Id: I18bbd668a16a5b350a14cfa565fb5b96ab205fe8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75011
Tested-by: core-ci <typo3@b13.com>
Tested-by: waldhacker <hello@waldhacker.dev>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: waldhacker <hello@waldhacker.dev>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
---
.../Public/JavaScript/Backend/FormEditor/InspectorComponent.js | 1 +
.../Resources/Public/JavaScript/Backend/FormEditor/Mediator.js | 2 --
.../Resources/Public/JavaScript/Backend/FormEditor/ViewModel.js | 1 +
3 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/InspectorComponent.js b/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/InspectorComponent.js
index 0a7c66bea9aa..5cebbdabb079 100644
--- a/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/InspectorComponent.js
+++ b/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/InspectorComponent.js
@@ -2564,6 +2564,7 @@ define(['jquery',
*
* @param string content
* @return void
+ * @deprecated not used anymore, will be removed in TYPO3 v12.0
*/
function setFormElementHeaderEditorContent(content) {
if (getFormEditorApp().getUtility().isUndefinedOrNull(content)) {
diff --git a/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/Mediator.js b/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/Mediator.js
index 2dcf42669258..d30c0d40b29f 100644
--- a/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/Mediator.js
+++ b/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/Mediator.js
@@ -823,11 +823,9 @@ define(['jquery',
if ('renderables' !== args[0]) {
if (!getFormEditorApp().isRootFormElementSelected() && 'label' === args[0]) {
getViewModel().getStructure().setTreeNodeTitle();
- getViewModel().setInspectorFormElementHeaderEditorContent();
} else if (!getFormEditorApp().getUtility().isUndefinedOrNull(args[3]) && getRootFormElement().get('__identifierPath') === args[3]) {
getViewModel().setStructureRootElementTitle();
getViewModel().setStageHeadline();
- getViewModel().setInspectorFormElementHeaderEditorContent();
}
if (getViewModel().getPreviewMode()) {
diff --git a/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/ViewModel.js b/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/ViewModel.js
index 3b790cfc9347..ccdbce9ba6ca 100644
--- a/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/ViewModel.js
+++ b/typo3/sysext/form/Resources/Public/JavaScript/Backend/FormEditor/ViewModel.js
@@ -882,6 +882,7 @@ define(['jquery',
*
* @param string content
* @return void
+ * @deprecated not used anymore, will be removed in TYPO3 v12.0
*/
function setInspectorFormElementHeaderEditorContent(content) {
getInspector().setFormElementHeaderEditorContent(content);
--
GitLab