From 77f5350a32a80e20598882a77e915121dddb4acb Mon Sep 17 00:00:00 2001
From: Nikita Hovratov <nikita.h@live.de>
Date: Thu, 12 Oct 2023 12:35:54 +0200
Subject: [PATCH] [TASK] Use descriptions over placeholders in sys_file_storage
It is best practice to use permanently visible information to help to
fill out forms of any kind. In case of sys_file_storage the placeholder
is even partially cut off, so one can't read the whole text.
Resolves: #102150
Releases: main, 12.4
Change-Id: I8ad357470b4ff7a42454aba77c14cc8b6a532e8b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81416
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Nikita Hovratov <nikita.h@live.de>
Reviewed-by: Nikita Hovratov <nikita.h@live.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
---
.../Configuration/Resource/Driver/LocalDriverFlexForm.xml | 4 ++--
typo3/sysext/core/Configuration/TCA/sys_file_storage.php | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/typo3/sysext/core/Configuration/Resource/Driver/LocalDriverFlexForm.xml b/typo3/sysext/core/Configuration/Resource/Driver/LocalDriverFlexForm.xml
index 8486a5ba18c3..0222c023f6d5 100644
--- a/typo3/sysext/core/Configuration/Resource/Driver/LocalDriverFlexForm.xml
+++ b/typo3/sysext/core/Configuration/Resource/Driver/LocalDriverFlexForm.xml
@@ -5,9 +5,9 @@
<el>
<basePath>
<label>LLL:EXT:core/Resources/Private/Language/locallang_mod_file.xlf:sys_file_storage.localDriverFlexform_basePath</label>
+ <description>LLL:EXT:core/Resources/Private/Language/locallang_mod_file.xlf:sys_file_storage.localDriverFlexform_basePath_placeholder</description>
<config>
<type>input</type>
- <placeholder>LLL:EXT:core/Resources/Private/Language/locallang_mod_file.xlf:sys_file_storage.localDriverFlexform_basePath_placeholder</placeholder>
<required>1</required>
<size>30</size>
</config>
@@ -31,9 +31,9 @@
</pathType>
<baseUri>
<label>LLL:EXT:core/Resources/Private/Language/locallang_mod_file.xlf:sys_file_storage.localDriverFlexform_baseUri</label>
+ <description>LLL:EXT:core/Resources/Private/Language/locallang_mod_file.xlf:sys_file_storage.localDriverFlexform_baseUri_placeholder</description>
<config>
<type>input</type>
- <placeholder>LLL:EXT:core/Resources/Private/Language/locallang_mod_file.xlf:sys_file_storage.localDriverFlexform_baseUri_placeholder</placeholder>
<size>30</size>
</config>
</baseUri>
diff --git a/typo3/sysext/core/Configuration/TCA/sys_file_storage.php b/typo3/sysext/core/Configuration/TCA/sys_file_storage.php
index 4ea5adb607e0..f75b365eded4 100644
--- a/typo3/sysext/core/Configuration/TCA/sys_file_storage.php
+++ b/typo3/sysext/core/Configuration/TCA/sys_file_storage.php
@@ -90,9 +90,9 @@ return [
],
'processingfolder' => [
'label' => 'LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file_storage.processingfolder',
+ 'description' => 'LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file_storage.processingfolder.placeholder',
'config' => [
'type' => 'input',
- 'placeholder' => 'LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file_storage.processingfolder.placeholder',
'size' => 20,
],
],
--
GitLab