From 76ac040036de1f0a62a99e200893618141802213 Mon Sep 17 00:00:00 2001
From: Christian Kuhn <lolli@schwarzbu.ch>
Date: Tue, 3 Oct 2017 14:13:55 +0200
Subject: [PATCH] [TASK] Acceptance tests: chrome headless

Switch to chrome headless for acceptance tests. We
don't need xvfb and friends on bamboo anymore which
will be updated with another patch later.

Change-Id: Ieb78d3d198f7dd9dc882041d86b403099e0854c6
Resolves: #82659
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54272
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
---
 typo3/sysext/core/Tests/Acceptance.suite.yml                  | 4 +---
 .../core/Tests/Acceptance/Backend/Topbar/SearchCest.php       | 4 ++--
 typo3/sysext/core/Tests/AcceptanceInstallMysql.suite.yml      | 4 +---
 typo3/sysext/core/Tests/AcceptanceInstallPgsql.suite.yml      | 4 +---
 4 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/typo3/sysext/core/Tests/Acceptance.suite.yml b/typo3/sysext/core/Tests/Acceptance.suite.yml
index 445e76462256..0f6a3c273e25 100644
--- a/typo3/sysext/core/Tests/Acceptance.suite.yml
+++ b/typo3/sysext/core/Tests/Acceptance.suite.yml
@@ -9,9 +9,7 @@ modules:
       url: http://localhost:8000/typo3temp/var/tests/acceptance
       browser: chrome
       port: 4444
-      window_size: 1280x1024
       wait: 1
-      restart: false
       capabilities:
         # Disable the "scroll to element before clicking" behavior as this breaks tests
         # where for example a fixed docbar is used. Selenium scrolls to the element before
@@ -21,4 +19,4 @@ modules:
         # You can simply do that by scrolling to it.
         elementScrollBehavior: 1
         chromeOptions:
-          args: [no-sandbox,disable-infobars,disable-notifications,disable-gpu,disable-software-rasterizer]
\ No newline at end of file
+          args: ["--headless", "--no-sandbox", "window-size=1280x1024"]
\ No newline at end of file
diff --git a/typo3/sysext/core/Tests/Acceptance/Backend/Topbar/SearchCest.php b/typo3/sysext/core/Tests/Acceptance/Backend/Topbar/SearchCest.php
index 51ae9789c7c2..d0bc94078cd2 100644
--- a/typo3/sysext/core/Tests/Acceptance/Backend/Topbar/SearchCest.php
+++ b/typo3/sysext/core/Tests/Acceptance/Backend/Topbar/SearchCest.php
@@ -64,13 +64,13 @@ class SearchCest
     public function searchForFancyTextAndCheckEmptyResultInfo(Admin $I)
     {
         $I->fillField('#live-search-box', 'Kasper = Jesus # joh316');
-        $I->waitForElementVisible(self::$topBarModuleSelector . ' ' . Topbar::$dropdownListSelector);
+        $I->waitForElementVisible(self::$topBarModuleSelector . ' ' . Topbar::$dropdownListSelector, 100);
 
         // tod0: check why TYPO3 does not return a result for "Kasper" by itself
         $I->canSee('No results found.', self::$topBarModuleSelector);
 
         $I->click(self::$topBarModuleSelector . ' .close');
-        $I->waitForElementNotVisible(self::$topBarModuleSelector . ' ' . Topbar::$dropdownListSelector);
+        $I->waitForElementNotVisible(self::$topBarModuleSelector . ' ' . Topbar::$dropdownListSelector, 100);
         $I->cantSeeInField('#live-search-box', 'Kasper = Jesus # joh316');
     }
 
diff --git a/typo3/sysext/core/Tests/AcceptanceInstallMysql.suite.yml b/typo3/sysext/core/Tests/AcceptanceInstallMysql.suite.yml
index b3ed454e0c61..913c495fb7a1 100644
--- a/typo3/sysext/core/Tests/AcceptanceInstallMysql.suite.yml
+++ b/typo3/sysext/core/Tests/AcceptanceInstallMysql.suite.yml
@@ -9,9 +9,7 @@ modules:
       url: http://localhost:8000/typo3temp/var/tests/acceptanceinstallmysql
       browser: chrome
       port: 4444
-      window_size: 1280x1024
       wait: 1
-      restart: false
       capabilities:
         # Disable the "scroll to element before clicking" behavior as this breaks tests
         # where for example a fixed docbar is used. Selenium scrolls to the element before
@@ -21,4 +19,4 @@ modules:
         # You can simply do that by scrolling to it.
         elementScrollBehavior: 1
         chromeOptions:
-          args: [no-sandbox,disable-infobars,disable-notifications,disable-gpu,disable-software-rasterizer]
\ No newline at end of file
+          args: ["--headless", "--no-sandbox", "window-size=1280x1024"]
\ No newline at end of file
diff --git a/typo3/sysext/core/Tests/AcceptanceInstallPgsql.suite.yml b/typo3/sysext/core/Tests/AcceptanceInstallPgsql.suite.yml
index fb578b0ba316..ff61dcf32a73 100644
--- a/typo3/sysext/core/Tests/AcceptanceInstallPgsql.suite.yml
+++ b/typo3/sysext/core/Tests/AcceptanceInstallPgsql.suite.yml
@@ -9,9 +9,7 @@ modules:
       url: http://localhost:8000/typo3temp/var/tests/acceptanceinstallpgsql
       browser: chrome
       port: 4444
-      window_size: 1280x1024
       wait: 1
-      restart: false
       capabilities:
         # Disable the "scroll to element before clicking" behavior as this breaks tests
         # where for example a fixed docbar is used. Selenium scrolls to the element before
@@ -21,4 +19,4 @@ modules:
         # You can simply do that by scrolling to it.
         elementScrollBehavior: 1
         chromeOptions:
-          args: [no-sandbox,disable-infobars,disable-notifications,disable-gpu,disable-software-rasterizer]
+          args: ["--headless", "--no-sandbox", "window-size=1280x1024"]
-- 
GitLab