From 738ac0cc941464df9da781b32a351f0d0631a131 Mon Sep 17 00:00:00 2001 From: Markus Klein <markus.klein@typo3.org> Date: Sun, 10 May 2020 22:28:55 +0200 Subject: [PATCH] [BUGFIX] Remove wrong MethodCallStaticMatchers Some methods have been added for this matcher, which are actually not deprecated/removed as a whole. Only the usage of those methods has been adjusted. The extension scanner is not capable of detecting such usages only, hence there is no sense in reporting every usage of those functions, albeit these usages might be valid. The matcher entries are removed therefore. Resolves: #91355 Releases: master Change-Id: I9da87ecb320f65d4fe5df168d788bb2ba8547f84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64451 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by: Benjamin Franzke <bfr@qbus.de> Reviewed-by: Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by: Benjamin Franzke <bfr@qbus.de> --- ...erClassesWhenRegisteringPluginsmodules.rst | 2 +- ...95-CallingRegisterPluginWithVendorName.rst | 2 +- .../Php/MethodCallStaticMatcher.php | 21 ------------------- 3 files changed, 2 insertions(+), 23 deletions(-) diff --git a/typo3/sysext/core/Documentation/Changelog/10.0/Deprecation-87550-UseControllerClassesWhenRegisteringPluginsmodules.rst b/typo3/sysext/core/Documentation/Changelog/10.0/Deprecation-87550-UseControllerClassesWhenRegisteringPluginsmodules.rst index 94085175f65a..19f034177b03 100644 --- a/typo3/sysext/core/Documentation/Changelog/10.0/Deprecation-87550-UseControllerClassesWhenRegisteringPluginsmodules.rst +++ b/typo3/sysext/core/Documentation/Changelog/10.0/Deprecation-87550-UseControllerClassesWhenRegisteringPluginsmodules.rst @@ -87,4 +87,4 @@ Migration * Omit the vendor name in argument :php:`$extensionName` * Use fully qualified class names as array keys in arguments :php:`$controllerActions` and :php:`$nonCacheableControllerActions` -.. index:: PHP-API, PartiallyScanned, ext:extbase +.. index:: PHP-API, NotScanned, ext:extbase diff --git a/typo3/sysext/core/Documentation/Changelog/10.1/Deprecation-88995-CallingRegisterPluginWithVendorName.rst b/typo3/sysext/core/Documentation/Changelog/10.1/Deprecation-88995-CallingRegisterPluginWithVendorName.rst index 35006f82e6b0..092703bed619 100644 --- a/typo3/sysext/core/Documentation/Changelog/10.1/Deprecation-88995-CallingRegisterPluginWithVendorName.rst +++ b/typo3/sysext/core/Documentation/Changelog/10.1/Deprecation-88995-CallingRegisterPluginWithVendorName.rst @@ -52,4 +52,4 @@ Just use the extension name like in this example. 'content-form', ); -.. index:: PHP-API, FullyScanned, ext:extbase +.. index:: PHP-API, NotScanned, ext:extbase diff --git a/typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php b/typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php index 1a8e32945c2f..868b7632a384 100644 --- a/typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php +++ b/typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php @@ -841,20 +841,6 @@ return [ 'Breaking-87193-DeprecatedFunctionalityRemoved.rst', ], ], - 'TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin' => [ - 'numberOfMandatoryArguments' => 3, - 'maximumNumberOfArguments' => 5, - 'restFiles' => [ - 'Deprecation-87550-UseControllerClassesWhenRegisteringPluginsmodules.rst', - ], - ], - 'TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule' => [ - 'numberOfMandatoryArguments' => 1, - 'maximumNumberOfArguments' => 6, - 'restFiles' => [ - 'Deprecation-87550-UseControllerClassesWhenRegisteringPluginsmodules.rst', - ], - ], 'TYPO3\CMS\Extbase\Reflection\ObjectAccess::buildSetterMethodName' => [ 'numberOfMandatoryArguments' => 1, 'maximumNumberOfArguments' => 1, @@ -932,13 +918,6 @@ return [ 'Deprecation-88787-BackendUtilityEditOnClick.rst' ], ], - 'TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerPlugin' => [ - 'numberOfMandatoryArguments' => 3, - 'maximumNumberOfArguments' => 4, - 'restFiles' => [ - 'Deprecation-88995-CallingRegisterPluginWithVendorName.rst' - ], - ], 'TYPO3\CMS\Core\Utility\GeneralUtility::getApplicationContext' => [ 'numberOfMandatoryArguments' => 0, 'maximumNumberOfArguments' => 0, -- GitLab