From 71bbf57d6829744a9649edc077167c0c42717b99 Mon Sep 17 00:00:00 2001
From: Benni Mack <benni@typo3.org>
Date: Mon, 23 Mar 2020 15:25:44 +0100
Subject: [PATCH] [BUGFIX] Differ between upload_max_filesize / post_max_size
The environment status should show proper information whether both
PHP.ini settings have the same value or differ (but post_max_size is higher
which is fine).
Resolves: #89543
Releases: master, 9.5
Change-Id: Ib589715507d7e929904366cbda9b33b45e254564
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63879
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Susanne Moog <look@susi.dev>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Susanne Moog <look@susi.dev>
---
typo3/sysext/install/Classes/SystemEnvironment/Check.php | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/typo3/sysext/install/Classes/SystemEnvironment/Check.php b/typo3/sysext/install/Classes/SystemEnvironment/Check.php
index cb0e7c2a2363..24c16cb59b1f 100644
--- a/typo3/sysext/install/Classes/SystemEnvironment/Check.php
+++ b/typo3/sysext/install/Classes/SystemEnvironment/Check.php
@@ -200,11 +200,16 @@ class Check implements CheckInterface
'Maximum size for POST requests is smaller than maximum upload filesize in PHP',
FlashMessage::ERROR
));
- } else {
+ } elseif ($maximumPostSize === $maximumUploadFilesize) {
$this->messageQueue->enqueue(new FlashMessage(
- 'The maximum size for file uploads is actually set to ' . ini_get('upload_max_filesize'),
+ 'The maximum size for file uploads is set to ' . ini_get('upload_max_filesize'),
'Maximum post upload size correlates with maximum upload file size in PHP'
));
+ } else {
+ $this->messageQueue->enqueue(new FlashMessage(
+ 'The maximum size for file uploads is set to ' . ini_get('upload_max_filesize'),
+ 'Maximum post upload size is higher than maximum upload file size in PHP, which is fine.'
+ ));
}
}
--
GitLab