From 6d7483a8aca4b75cfc5d62fadfee71b9d9947c35 Mon Sep 17 00:00:00 2001 From: Helmut Hummel <typo3@helhum.io> Date: Thu, 7 Sep 2023 11:08:24 +0200 Subject: [PATCH] [BUGFIX] Make WebserverType an optional argument MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There is no downside in making the argument optional. Although the API is marked as internal, it is in use in third party code, which would break within a bugfix release. Logically the API makes total sense with the argument being optional. If the webserver type is not known or not provided, no additional file is created. Resolves: #101868 Releases: main, 12.4 Change-Id: Ie559b8685fc582681befe09ff769724f13639862 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80894 Reviewed-by: Stefan Bürk <stefan@buerk.tech> Tested-by: Stefan Bürk <stefan@buerk.tech> Tested-by: core-ci <typo3@b13.com> --- typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php b/typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php index 50edb28a6e86..c2441c2e7d19 100644 --- a/typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php +++ b/typo3/sysext/install/Classes/FolderStructure/DefaultFactory.php @@ -31,7 +31,7 @@ class DefaultFactory * * @return StructureFacadeInterface */ - public function getStructure(WebserverType $webserverType) + public function getStructure(WebserverType $webserverType = WebserverType::Other) { $rootNode = new RootNode($this->getDefaultStructureDefinition($webserverType), null); return new StructureFacade($rootNode); -- GitLab