From 6b13e12b95e64816bf835927140f84725e50e377 Mon Sep 17 00:00:00 2001
From: Susanne Moog <susanne.moog@typo3.com>
Date: Wed, 4 Oct 2017 09:39:28 +0200
Subject: [PATCH] [BUGFIX] Do not GROUP BY alias in WorkspaceService
GROUP BY statements are in general evaluated before
SELECT statements. If a DBMS does not implement additional
logic to resolve aliases defined in SELECTS before grouping
the statement will fail. Currently both MSSQL as well as ORACLE
lack these additional implementations. To be safe we should
group by the non-aliased columns.
Change-Id: I04698b2c31fbe2b0907fd345fbbf5e84dcebf164
Resolves: #82664
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54281
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
---
typo3/sysext/workspaces/Classes/Service/WorkspaceService.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/typo3/sysext/workspaces/Classes/Service/WorkspaceService.php b/typo3/sysext/workspaces/Classes/Service/WorkspaceService.php
index 6ca08acad94c..abf888bf89a9 100644
--- a/typo3/sysext/workspaces/Classes/Service/WorkspaceService.php
+++ b/typo3/sysext/workspaces/Classes/Service/WorkspaceService.php
@@ -1071,7 +1071,7 @@ class WorkspaceService implements SingletonInterface
$movePointerQueryBuilder->getSQL()
)
)
- ->groupBy('pageId')
+ ->groupBy('B.pid')
->execute();
$pageIds = [];
--
GitLab