From 69f66f64d294b698c288a88bf53e0ec3be77f320 Mon Sep 17 00:00:00 2001 From: Oliver Klee <typo3-coding@oliverklee.de> Date: Sat, 17 Dec 2022 16:11:14 +0100 Subject: [PATCH] [TASK] Update to PHPStan 1.9.12 The new version finds some more potential problems. > composer req --dev phpstan/phpstan:^1.9.12 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #99573 Releases: main, 11.5 Change-Id: Ieee3a5881a854946cb180965e4f182b27ea05aaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77420 Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: core-ci <typo3@b13.com> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> --- Build/phpstan/phpstan-baseline.neon | 5 +++++ composer.json | 2 +- composer.lock | 14 +++++++------- 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/Build/phpstan/phpstan-baseline.neon b/Build/phpstan/phpstan-baseline.neon index 2cdcde9298a0..90bfa97cda4b 100644 --- a/Build/phpstan/phpstan-baseline.neon +++ b/Build/phpstan/phpstan-baseline.neon @@ -640,6 +640,11 @@ parameters: count: 1 path: ../../typo3/sysext/core/Classes/Core/ClassLoadingInformationGenerator.php + - + message: "#^Binary operation \"&\" between string and int\\<1, max\\> results in an error\\.$#" + count: 1 + path: ../../typo3/sysext/core/Classes/DataHandling/DataHandler.php + - message: "#^Binary operation \"\\*\\=\" between non\\-falsy\\-string and \\-1 results in an error\\.$#" count: 1 diff --git a/composer.json b/composer.json index 079910360e1c..e706250e5bfc 100644 --- a/composer.json +++ b/composer.json @@ -119,7 +119,7 @@ "php-webdriver/webdriver": "^1.12.0", "phpspec/prophecy": "^1.15.0", "phpspec/prophecy-phpunit": "^2.0.1", - "phpstan/phpstan": "^1.9.5", + "phpstan/phpstan": "^1.9.12", "phpstan/phpstan-phpunit": "^1.3.3", "phpunit/phpunit": "^9.5.21", "typo3/cms-styleguide": "~11.5.4", diff --git a/composer.lock b/composer.lock index dccaab4fdf23..24e01bfd4bce 100644 --- a/composer.lock +++ b/composer.lock @@ -4,7 +4,7 @@ "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies", "This file is @generated automatically" ], - "content-hash": "3f12754b531c1c66b7ac71dc9ac87016", + "content-hash": "e0635b609153bf758fdaf934a97b4694", "packages": [ { "name": "bacon/bacon-qr-code", @@ -7151,16 +7151,16 @@ }, { "name": "phpstan/phpstan", - "version": "1.9.5", + "version": "1.9.12", "source": { "type": "git", "url": "https://github.com/phpstan/phpstan.git", - "reference": "4d18c5d98965029c2aa1ccbd91dc22e7ba8c5034" + "reference": "44a338ff0d5572c13fd77dfd91addb96e48c29f8" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/phpstan/phpstan/zipball/4d18c5d98965029c2aa1ccbd91dc22e7ba8c5034", - "reference": "4d18c5d98965029c2aa1ccbd91dc22e7ba8c5034", + "url": "https://api.github.com/repos/phpstan/phpstan/zipball/44a338ff0d5572c13fd77dfd91addb96e48c29f8", + "reference": "44a338ff0d5572c13fd77dfd91addb96e48c29f8", "shasum": "" }, "require": { @@ -7190,7 +7190,7 @@ ], "support": { "issues": "https://github.com/phpstan/phpstan/issues", - "source": "https://github.com/phpstan/phpstan/tree/1.9.5" + "source": "https://github.com/phpstan/phpstan/tree/1.9.12" }, "funding": [ { @@ -7206,7 +7206,7 @@ "type": "tidelift" } ], - "time": "2023-01-02T21:35:42+00:00" + "time": "2023-01-17T10:44:04+00:00" }, { "name": "phpstan/phpstan-phpunit", -- GitLab