From 671d0b70e737fa96a4e1526b7c90b87061ab61df Mon Sep 17 00:00:00 2001
From: Nicole Cordes <typo3@cordes.co>
Date: Thu, 8 Oct 2015 23:47:24 +0200
Subject: [PATCH] [TASK] Add autocomplete="off" to Install Tool fields
This patch adds the input attribute autocomplete="off" to form fields
in the Install Tool to prevent auto completion for username and
password fields.
Resolves: #70516
Releases: master
Change-Id: I8f3d72e817e45569050baa89636d46242c13cd2f
Reviewed-on: http://review.typo3.org/43919
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
---
.../Step/DatabaseConnect/ConnectDetails.html | 4 ++--
.../ImportantActions/CreateAdministrator.html | 3 +++
.../NewInstallToolPassword.html | 22 ++++++++++---------
.../Templates/Action/Step/DatabaseData.html | 2 ++
4 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/typo3/sysext/install/Resources/Private/Partials/Action/Step/DatabaseConnect/ConnectDetails.html b/typo3/sysext/install/Resources/Private/Partials/Action/Step/DatabaseConnect/ConnectDetails.html
index f5c44a5d9959..417e50c8be30 100644
--- a/typo3/sysext/install/Resources/Private/Partials/Action/Step/DatabaseConnect/ConnectDetails.html
+++ b/typo3/sysext/install/Resources/Private/Partials/Action/Step/DatabaseConnect/ConnectDetails.html
@@ -7,14 +7,14 @@
<f:if condition="{renderConnectDetailsUsername}">
<li>
<label for="t3-install-step-username">Username</label>
- <input id="t3-install-step-username" class="t3-install-form-input-text" type="text" value="{username}" name="install[values][username]" />
+ <input id="t3-install-step-username" class="t3-install-form-input-text" type="text" value="{username}" name="install[values][username]" autocomplete="off" />
</li>
</f:if>
<f:if condition="{renderConnectDetailsPassword}">
<li>
<label for="t3-install-step-password">Password</label>
- <input id="t3-install-step-password" class="t3-install-form-input-text" type="password" value="{password}" name="install[values][password]" />
+ <input id="t3-install-step-password" class="t3-install-form-input-text" type="password" value="{password}" name="install[values][password]" autocomplete="off" />
</li>
</f:if>
diff --git a/typo3/sysext/install/Resources/Private/Partials/Action/Tool/ImportantActions/CreateAdministrator.html b/typo3/sysext/install/Resources/Private/Partials/Action/Tool/ImportantActions/CreateAdministrator.html
index 90794d43c650..06d679323b72 100644
--- a/typo3/sysext/install/Resources/Private/Partials/Action/Tool/ImportantActions/CreateAdministrator.html
+++ b/typo3/sysext/install/Resources/Private/Partials/Action/Tool/ImportantActions/CreateAdministrator.html
@@ -14,6 +14,7 @@
class="t3-install-form-input-text"
type="text"
name="install[values][newUserUsername]"
+ autocomplete="off"
/>
</li>
<li>
@@ -23,6 +24,7 @@
class="t3-install-form-input-text t3-install-form-password-strength"
type="password"
name="install[values][newUserPassword]"
+ autocomplete="off"
/>
</li>
<li>
@@ -32,6 +34,7 @@
class="t3-install-form-input-text"
type="password"
name="install[values][newUserPasswordCheck]"
+ autocomplete="off"
/>
</li>
</ol>
diff --git a/typo3/sysext/install/Resources/Private/Partials/Action/Tool/ImportantActions/NewInstallToolPassword.html b/typo3/sysext/install/Resources/Private/Partials/Action/Tool/ImportantActions/NewInstallToolPassword.html
index 1d2361497ca3..eb9b0e3796e9 100644
--- a/typo3/sysext/install/Resources/Private/Partials/Action/Tool/ImportantActions/NewInstallToolPassword.html
+++ b/typo3/sysext/install/Resources/Private/Partials/Action/Tool/ImportantActions/NewInstallToolPassword.html
@@ -6,20 +6,22 @@
<li>
<label for="t3-install-password">Enter new password:</label>
<input
- id="t3-install-password"
- class="t3-install-form-input-text t3-install-form-password-strength"
- type="password"
- name="install[values][newInstallToolPassword]"
- />
+ id="t3-install-password"
+ class="t3-install-form-input-text t3-install-form-password-strength"
+ type="password"
+ name="install[values][newInstallToolPassword]"
+ autocomplete="off"
+ />
</li>
<li>
<label for="t3-install-password-repeat">Repeat password:</label>
<input
- id="t3-install-password-repeat"
- class="t3-install-form-input-text"
- type="password"
- name="install[values][newInstallToolPasswordCheck]"
- />
+ id="t3-install-password-repeat"
+ class="t3-install-form-input-text"
+ type="password"
+ name="install[values][newInstallToolPasswordCheck]"
+ autocomplete="off"
+ />
</li>
</ol>
</fieldset>
diff --git a/typo3/sysext/install/Resources/Private/Templates/Action/Step/DatabaseData.html b/typo3/sysext/install/Resources/Private/Templates/Action/Step/DatabaseData.html
index 21407ff8b13f..308658f56190 100644
--- a/typo3/sysext/install/Resources/Private/Templates/Action/Step/DatabaseData.html
+++ b/typo3/sysext/install/Resources/Private/Templates/Action/Step/DatabaseData.html
@@ -26,6 +26,7 @@
name="install[values][username]"
id="username"
placeholder="admin"
+ autocomplete="off"
/>
</li>
@@ -36,6 +37,7 @@
name="install[values][password]"
id="password"
type="password"
+ autocomplete="off"
/>
</li>
--
GitLab