From 6190341ff3894637919ba1b7595a9e84558d7b30 Mon Sep 17 00:00:00 2001
From: Benni Mack <benni@typo3.org>
Date: Thu, 16 Nov 2017 22:26:52 +0100
Subject: [PATCH] [TASK] Resolve translated page IDs to default language page
in FE
Currently, when accessing a translated page ID via index.php?id=23,
the TypoScript cannot be resolved, as the GET parameter is no valid
page where records (e.g. sys_template etc).
In order to achieve this, the TYPO3 Frontend now resolves the $id
to the default page ID, but also sets $this->sys_language_uid and
$this->sys_language_content.
Resolves: #83017
Releases: master
Change-Id: I910909ce52c2efdb02717952d67e17d8897f4d17
Reviewed-on: https://review.typo3.org/54670
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
---
.../TypoScriptFrontendController.php | 29 +++++++++++++++++--
1 file changed, 26 insertions(+), 3 deletions(-)
diff --git a/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php b/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
index c76840693de3..5fdd29043964 100644
--- a/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
+++ b/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
@@ -1408,7 +1408,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface
*/
public function getPageAndRootline()
{
- $this->page = $this->sys_page->getPage($this->id);
+ $this->resolveTranslatedPageId();
if (empty($this->page)) {
// If no page, we try to find the page before in the rootLine.
// Page is 'not found' in case the id itself was not an accessible page. code 1
@@ -1506,6 +1506,27 @@ class TypoScriptFrontendController implements LoggerAwareInterface
}
}
+ /**
+ * If $this->id contains a translated page record, this needs to be resolved to the default language
+ * in order for all rootline functionality and access restrictions to be in place further on.
+ *
+ * Additionally, if a translated page is found, $this->sys_language_uid/sys_language_content is set as well.
+ */
+ protected function resolveTranslatedPageId()
+ {
+ $this->page = $this->sys_page->getPage($this->id);
+ // Accessed a default language page record, nothing to resolve
+ if (empty($this->page) || (int)$this->page[$GLOBALS['TCA']['pages']['ctrl']['languageField']] === 0) {
+ return;
+ }
+ $this->sys_language_uid = (int)$this->page[$GLOBALS['TCA']['pages']['ctrl']['languageField']];
+ $this->sys_language_content = $this->sys_language_uid;
+ $this->page = $this->sys_page->getPage($this->page[$GLOBALS['TCA']['pages']['ctrl']['transOrigPointerField']]);
+ $this->id = $this->page['uid'];
+ // For common best-practice reasons, this is set, however, will be optional for new routing mechanisms
+ $this->mergingWithGetVars(['L' => $this->sys_language_uid]);
+ }
+
/**
* Get page shortcut; Finds the records pointed to by input value $SC (the shortcut value)
*
@@ -2510,8 +2531,10 @@ class TypoScriptFrontendController implements LoggerAwareInterface
$this->metaCharset = $this->config['config']['metaCharset'];
}
- // Get values from TypoScript:
- $this->sys_language_uid = ($this->sys_language_content = (int)$this->config['config']['sys_language_uid']);
+ // Get values from TypoScript, if not set before
+ if ($this->sys_language_uid === 0) {
+ $this->sys_language_uid = ($this->sys_language_content = (int)$this->config['config']['sys_language_uid']);
+ }
list($this->sys_language_mode, $sys_language_content) = GeneralUtility::trimExplode(';', $this->config['config']['sys_language_mode']);
$this->sys_language_contentOL = $this->config['config']['sys_language_overlay'];
// If sys_language_uid is set to another language than default:
--
GitLab