From 5b9335d244c7361e3868996739efde4956aa52b3 Mon Sep 17 00:00:00 2001
From: DanielRuf <daniel@daniel-ruf.de>
Date: Sat, 10 Jun 2017 23:58:51 +0200
Subject: [PATCH] [TASK] change intval() to (int)
Typecasting with (int) is about 2-3 times faster than using intval().
Change-Id: Ifddcaaf9bf5c1fa77c632df10cba62c82d4614d1
Resolves: #81544
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53183
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
---
.../indexed_search/Classes/Controller/SearchController.php | 4 ++--
.../recycler/Classes/Controller/RecyclerModuleController.php | 4 ++--
.../workspaces/Classes/Controller/AbstractController.php | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/typo3/sysext/indexed_search/Classes/Controller/SearchController.php b/typo3/sysext/indexed_search/Classes/Controller/SearchController.php
index 0301b236fa41..5edf1f0f6846 100644
--- a/typo3/sysext/indexed_search/Classes/Controller/SearchController.php
+++ b/typo3/sysext/indexed_search/Classes/Controller/SearchController.php
@@ -1312,7 +1312,7 @@ class SearchController extends \TYPO3\CMS\Extbase\Mvc\Controller\ActionControlle
if ($row['data_page_mp']) {
$urlParameters['MP'] = $row['data_page_mp'];
}
- $urlParameters['L'] = intval($row['sys_language_uid']);
+ $urlParameters['L'] = (int)$row['sys_language_uid'];
// markup-GET vars:
$urlParameters = array_merge($urlParameters, $markUpSwParams);
// This will make sure that the path is retrieved if it hasn't been
@@ -1544,7 +1544,7 @@ class SearchController extends \TYPO3\CMS\Extbase\Mvc\Controller\ActionControlle
*/
protected function getNumberOfResults($numberOfResults)
{
- $numberOfResults = intval($numberOfResults);
+ $numberOfResults = (int)$numberOfResults;
return (in_array($numberOfResults, $this->availableResultsNumbers)) ?
$numberOfResults : $this->defaultResultNumber;
diff --git a/typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php b/typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php
index dfc84e1dc673..f6e98fc21527 100644
--- a/typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php
+++ b/typo3/sysext/recycler/Classes/Controller/RecyclerModuleController.php
@@ -97,8 +97,8 @@ class RecyclerModuleController extends ActionController
$this->allowDelete = (bool)$modTS['properties']['allowDelete'];
}
- if (isset($modTS['properties']['recordsPageLimit']) && intval($modTS['properties']['recordsPageLimit']) > 0) {
- $this->recordsPageLimit = intval($modTS['properties']['recordsPageLimit']);
+ if (isset($modTS['properties']['recordsPageLimit']) && (int)$modTS['properties']['recordsPageLimit'] > 0) {
+ $this->recordsPageLimit = (int)$modTS['properties']['recordsPageLimit'];
}
}
diff --git a/typo3/sysext/workspaces/Classes/Controller/AbstractController.php b/typo3/sysext/workspaces/Classes/Controller/AbstractController.php
index 1b530aa5597c..40eb4449880d 100644
--- a/typo3/sysext/workspaces/Classes/Controller/AbstractController.php
+++ b/typo3/sysext/workspaces/Classes/Controller/AbstractController.php
@@ -59,7 +59,7 @@ class AbstractController extends ActionController
protected function initializeAction()
{
$this->pageRenderer = $this->getPageRenderer();
- // @todo Evaluate how the intval() call can be used with Extbase validators/filters
+ // @todo Evaluate how the (int) typecast can be used with Extbase validators/filters
$this->pageId = (int)GeneralUtility::_GP('id');
$iconFactory = GeneralUtility::makeInstance(IconFactory::class);
$lang = $this->getLanguageService();
--
GitLab