From 5a8817d2353854798c0438e223374373fa6035d0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sascha=20L=C3=B6ffler?= <lsascha@gmail.com>
Date: Fri, 16 Mar 2018 22:38:06 +0100
Subject: [PATCH] [TASK] Make IconViewHelperTest notice free
Resolves: #84382
Releases: master
Change-Id: Ie3636104caf9ce61da3071ab738cb0e1f7a05e89
Reviewed-on: https://review.typo3.org/56262
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
---
.../Unit/ViewHelpers/IconViewHelperTest.php | 23 +++++++++++--------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/typo3/sysext/core/Tests/Unit/ViewHelpers/IconViewHelperTest.php b/typo3/sysext/core/Tests/Unit/ViewHelpers/IconViewHelperTest.php
index 265eafe6f617..5598b985df11 100644
--- a/typo3/sysext/core/Tests/Unit/ViewHelpers/IconViewHelperTest.php
+++ b/typo3/sysext/core/Tests/Unit/ViewHelpers/IconViewHelperTest.php
@@ -1,4 +1,5 @@
<?php
+declare(strict_types = 1);
namespace TYPO3\CMS\Core\Tests\Unit\ViewHelpers;
/*
@@ -27,11 +28,6 @@ use TYPO3\TestingFramework\Fluid\Unit\ViewHelpers\ViewHelperBaseTestcase;
*/
class IconViewHelperTest extends ViewHelperBaseTestcase
{
- /**
- * Subject is not notice free, disable E_NOTICES
- */
- protected static $suppressNotices = true;
-
/**
* @var IconViewHelper
*/
@@ -59,7 +55,10 @@ class IconViewHelperTest extends ViewHelperBaseTestcase
$this->viewHelper->setArguments([
'identifier' => 'myIdentifier',
- 'size' => Icon::SIZE_SMALL
+ 'size' => Icon::SIZE_SMALL,
+ 'overlay' => null,
+ 'state' => IconState::cast(IconState::STATE_DEFAULT),
+ 'alternativeMarkupIdentifier' => null
]);
$this->assertSame('htmlFoo', $this->viewHelper->render());
@@ -79,7 +78,10 @@ class IconViewHelperTest extends ViewHelperBaseTestcase
$this->viewHelper->setArguments([
'identifier' => 'myIdentifier',
- 'size' => Icon::SIZE_LARGE
+ 'size' => Icon::SIZE_LARGE,
+ 'overlay' => null,
+ 'state' => IconState::cast(IconState::STATE_DEFAULT),
+ 'alternativeMarkupIdentifier' => null
]);
$this->assertSame('htmlFoo', $this->viewHelper->render());
@@ -101,7 +103,8 @@ class IconViewHelperTest extends ViewHelperBaseTestcase
'identifier' => 'myIdentifier',
'size' => Icon::SIZE_SMALL,
'overlay' => null,
- 'state' => IconState::cast(IconState::STATE_DISABLED)
+ 'state' => IconState::cast(IconState::STATE_DISABLED),
+ 'alternativeMarkupIdentifier' => null
]);
$this->assertSame('htmlFoo', $this->viewHelper->render());
@@ -122,7 +125,9 @@ class IconViewHelperTest extends ViewHelperBaseTestcase
$this->viewHelper->setArguments([
'identifier' => 'myIdentifier',
'size' => Icon::SIZE_LARGE,
- 'overlay' => 'overlayString'
+ 'overlay' => 'overlayString',
+ 'state' => IconState::cast(IconState::STATE_DEFAULT),
+ 'alternativeMarkupIdentifier' => null
]);
$this->assertSame('htmlFoo', $this->viewHelper->render());
}
--
GitLab