From 5a1e80cbb6e09e984be334f4bf72916a2686209b Mon Sep 17 00:00:00 2001
From: Georg Ringer <georg.ringer@gmail.com>
Date: Fri, 17 Mar 2023 10:59:47 +0100
Subject: [PATCH] [BUGFIX] Unify MetaTagApi removal methods
Add strtolower calls at `GenericMetaTagManager::removeProperty` to be in
sync with `PageRenderer::removeMetaTag`.
Resolves: #100198
Releases: main, 11.5
Change-Id: If758375d3293cbcd8897891a866c6cf6fb6df508
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78064
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: core-ci <typo3@b13.com>
---
typo3/sysext/core/Classes/MetaTag/GenericMetaTagManager.php | 3 +++
.../core/Tests/Unit/MetaTag/GenericMetaTagManagerTest.php | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/typo3/sysext/core/Classes/MetaTag/GenericMetaTagManager.php b/typo3/sysext/core/Classes/MetaTag/GenericMetaTagManager.php
index 655fae02baf2..60d5ff64b4b9 100644
--- a/typo3/sysext/core/Classes/MetaTag/GenericMetaTagManager.php
+++ b/typo3/sysext/core/Classes/MetaTag/GenericMetaTagManager.php
@@ -143,6 +143,9 @@ final class GenericMetaTagManager implements MetaTagManagerInterface
*/
public function removeProperty(string $property, string $type = '')
{
+ $property = strtolower($property);
+ $type = strtolower($type);
+
if (!empty($type)) {
unset($this->properties[$property][$type]);
} else {
diff --git a/typo3/sysext/core/Tests/Unit/MetaTag/GenericMetaTagManagerTest.php b/typo3/sysext/core/Tests/Unit/MetaTag/GenericMetaTagManagerTest.php
index b19995e2fa1d..0f68373bca99 100644
--- a/typo3/sysext/core/Tests/Unit/MetaTag/GenericMetaTagManagerTest.php
+++ b/typo3/sysext/core/Tests/Unit/MetaTag/GenericMetaTagManagerTest.php
@@ -146,7 +146,7 @@ class GenericMetaTagManagerTest extends UnitTestCase
self::assertEquals([['content' => 'Description 1', 'subProperties' => []]], $manager->getProperty('description', 'property'));
- $manager->removeProperty('description', 'property');
+ $manager->removeProperty('Description', 'Property');
self::assertEquals([], $manager->getProperty('description', 'property'));
self::assertEquals(
[
--
GitLab