From 57c3b27960e2cab2db2ca4bc3e4ae501082e8578 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jasmina=20Lie=C3=9Fmann?= <minapokhalo+typo3@gmail.com>
Date: Tue, 11 Jun 2024 14:48:38 +0200
Subject: [PATCH] [TASK] Update bookmark related link titles
The TYPO3 backend has a bookmark function with which records can be
saved as bookmarks. Since any other record type can be saved in
addition to pages, the corresponding link titles are now adjusted.
Resolves: #104053
Releases: main, 12.4
Change-Id: If8c894bdcd6e2aa0cbe3c29276a32ac18355a370
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84678
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
---
.../Tests/Functional/Template/Fixtures/RecordList.html | 4 ++--
.../Template/Fixtures/RecordListCopyToClipboard.html | 10 +++++-----
.../Template/Fixtures/RecordListSingleTable.html | 4 ++--
.../Fixtures/RecordListSingleTableCopyToClipboard.html | 10 +++++-----
.../Template/Fixtures/SpecialRouteIdentifier.html | 4 ++--
.../Fixtures/SpecialRouteIdentifierWithArguments.html | 4 ++--
...ialRouteIdentifierWithArgumentsCopyToClipboard.html | 10 +++++-----
.../core/Resources/Private/Language/locallang_core.xlf | 6 +++---
8 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordList.html b/typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordList.html
index 051b1edb8fa5..157f9789db37 100644
--- a/typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordList.html
+++ b/typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordList.html
@@ -1,8 +1,8 @@
<button
data-dispatch-action="TYPO3.ShortcutMenu.createShortcut"
- data-dispatch-args="[&quot;web_list&quot;,&quot;[]&quot;,&quot;Recordlist&quot;,&quot;Create a bookmark to this page&quot;,&quot;{$target}&quot;]"
+ data-dispatch-args="[&quot;web_list&quot;,&quot;[]&quot;,&quot;Recordlist&quot;,&quot;Create a bookmark to this record&quot;,&quot;{$target}&quot;]"
class="btn btn-sm btn-default"
- title="Create a bookmark to this page">
+ title="Create a bookmark to this record">
<span
class="t3js-icon icon icon-size-small icon-state-default icon-actions-system-shortcut-new"
data-identifier="actions-system-shortcut-new" aria-hidden="true">
diff --git a/typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListCopyToClipboard.html b/typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListCopyToClipboard.html
index 606d2944d286..cefd8c9580cf 100644
--- a/typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListCopyToClipboard.html
+++ b/typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListCopyToClipboard.html
@@ -12,9 +12,9 @@
<li>
<button
data-dispatch-action="TYPO3.ShortcutMenu.createShortcut"
- data-dispatch-args="[&quot;web_list&quot;,&quot;[]&quot;,&quot;Recordlist&quot;,&quot;Create a bookmark to this page&quot;,&quot;{$target}&quot;]"
+ data-dispatch-args="[&quot;web_list&quot;,&quot;[]&quot;,&quot;Recordlist&quot;,&quot;Create a bookmark to this record&quot;,&quot;{$target}&quot;]"
class="dropdown-item dropdown-item-spaced"
- title="Create a bookmark to this page">
+ title="Create a bookmark to this record">
<span
class="t3js-icon icon icon-size-small icon-state-default icon-actions-system-shortcut-new"
data-identifier="actions-system-shortcut-new" aria-hidden="true">
@@ -23,14 +23,14 @@
<use xlink:href="typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/actions.svg#actions-star" />
</svg>
</span>
- </span>Create a bookmark to this page
+ </span>Create a bookmark to this record
</button>
</li>
<li>
<typo3-copy-to-clipboard
text="http://example.com/typo3/module/web/list"
class="dropdown-item dropdown-item-spaced"
- title="Copy URL of this page">
+ title="Copy URL of this record">
<span
class="t3js-icon icon icon-size-small icon-state-default icon-actions-link"
data-identifier="actions-link" aria-hidden="true">
@@ -39,7 +39,7 @@
<use xlink:href="typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/actions.svg#actions-link" />
</svg>
</span>
- </span>Copy URL of this page
+ </span>Copy URL of this record
</typo3-copy-to-clipboard>
</li>
</ul>
diff --git a/typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTable.html b/typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTable.html
index 43f9814c36d4..e70516f05b23 100644
--- a/typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTable.html
+++ b/typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTable.html
@@ -1,8 +1,8 @@
<button
data-dispatch-action="TYPO3.ShortcutMenu.createShortcut"
- data-dispatch-args="[&quot;web_list&quot;,&quot;{\u0022id\u0022:123,\u0022table\u0022:\u0022some_table\u0022,\u0022GET\u0022:{\u0022clipBoard\u0022:1}}&quot;,&quot;Recordlist - single table view&quot;,&quot;Create a bookmark to this page&quot;,&quot;{$target}&quot;]"
+ data-dispatch-args="[&quot;web_list&quot;,&quot;{\u0022id\u0022:123,\u0022table\u0022:\u0022some_table\u0022,\u0022GET\u0022:{\u0022clipBoard\u0022:1}}&quot;,&quot;Recordlist - single table view&quot;,&quot;Create a bookmark to this record&quot;,&quot;{$target}&quot;]"
class="btn btn-sm btn-default"
- title="Create a bookmark to this page">
+ title="Create a bookmark to this record">
<span class="t3js-icon icon icon-size-small icon-state-default icon-actions-system-shortcut-new" data-identifier="actions-system-shortcut-new" aria-hidden="true">
<span class="icon-markup">
<svg class="icon-color">
diff --git a/typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTableCopyToClipboard.html b/typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTableCopyToClipboard.html
index 9fe5cabb7fa1..51826a3679b0 100644
--- a/typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTableCopyToClipboard.html
+++ b/typo3/sysext/backend/Tests/Functional/Template/Fixtures/RecordListSingleTableCopyToClipboard.html
@@ -19,8 +19,8 @@
<li>
<button
data-dispatch-action="TYPO3.ShortcutMenu.createShortcut"
- data-dispatch-args="[&quot;web_list&quot;,&quot;{\u0022id\u0022:123,\u0022table\u0022:\u0022some_table\u0022,\u0022GET\u0022:{\u0022clipBoard\u0022:1}}&quot;,&quot;Recordlist - single table view&quot;,&quot;Create a bookmark to this page&quot;,&quot;{$target}&quot;]"
- class="dropdown-item dropdown-item-spaced" title="Create a bookmark to this page">
+ data-dispatch-args="[&quot;web_list&quot;,&quot;{\u0022id\u0022:123,\u0022table\u0022:\u0022some_table\u0022,\u0022GET\u0022:{\u0022clipBoard\u0022:1}}&quot;,&quot;Recordlist - single table view&quot;,&quot;Create a bookmark to this record&quot;,&quot;{$target}&quot;]"
+ class="dropdown-item dropdown-item-spaced" title="Create a bookmark to this record">
<span
class="t3js-icon icon icon-size-small icon-state-default icon-actions-system-shortcut-new"
data-identifier="actions-system-shortcut-new" aria-hidden="true">
@@ -29,14 +29,14 @@
<use xlink:href="typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/actions.svg#actions-star" />
</svg>
</span>
- </span>Create a bookmark to this page
+ </span>Create a bookmark to this record
</button>
</li>
<li>
<typo3-copy-to-clipboard
text="http://example.com/typo3/module/web/list?id=123&table=some_table&GET%5BclipBoard%5D=1"
class="dropdown-item dropdown-item-spaced"
- title="Copy URL of this page">
+ title="Copy URL of this record">
<span
class="t3js-icon icon icon-size-small icon-state-default icon-actions-link"
data-identifier="actions-link" aria-hidden="true">
@@ -45,7 +45,7 @@
<use xlink:href="typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/actions.svg#actions-link" />
</svg>
</span>
- </span>Copy URL of this page
+ </span>Copy URL of this record
</typo3-copy-to-clipboard>
</li>
</ul>
diff --git a/typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifier.html b/typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifier.html
index 765db28f8239..7da63943cbd6 100644
--- a/typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifier.html
+++ b/typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifier.html
@@ -1,8 +1,8 @@
<button
data-dispatch-action="TYPO3.ShortcutMenu.createShortcut"
- data-dispatch-args="[&quot;record_edit&quot;,&quot;[]&quot;,&quot;Edit record&quot;,&quot;Create a bookmark to this page&quot;,&quot;{$target}&quot;]"
+ data-dispatch-args="[&quot;record_edit&quot;,&quot;[]&quot;,&quot;Edit record&quot;,&quot;Create a bookmark to this record&quot;,&quot;{$target}&quot;]"
class="btn btn-sm btn-default"
- title="Create a bookmark to this page">
+ title="Create a bookmark to this record">
<span
class="t3js-icon icon icon-size-small icon-state-default icon-actions-system-shortcut-new"
data-identifier="actions-system-shortcut-new" aria-hidden="true">
diff --git a/typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArguments.html b/typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArguments.html
index e7baab0bd933..48c4fa8b60ba 100644
--- a/typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArguments.html
+++ b/typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArguments.html
@@ -1,8 +1,8 @@
<button
data-dispatch-action="TYPO3.ShortcutMenu.createShortcut"
- data-dispatch-args="[&quot;record_edit&quot;,&quot;{\u0022id\u0022:123,\u0022edit\u0022:{\u0022pages\u0022:{\u0022123\u0022:\u0022edit\u0022},\u0022overrideVals\u0022:{\u0022pages\u0022:{\u0022sys_language_uid\u0022:1}}}}&quot;,&quot;Edit record&quot;,&quot;Create a bookmark to this page&quot;,&quot;{$target}&quot;]"
+ data-dispatch-args="[&quot;record_edit&quot;,&quot;{\u0022id\u0022:123,\u0022edit\u0022:{\u0022pages\u0022:{\u0022123\u0022:\u0022edit\u0022},\u0022overrideVals\u0022:{\u0022pages\u0022:{\u0022sys_language_uid\u0022:1}}}}&quot;,&quot;Edit record&quot;,&quot;Create a bookmark to this record&quot;,&quot;{$target}&quot;]"
class="btn btn-sm btn-default"
- title="Create a bookmark to this page">
+ title="Create a bookmark to this record">
<span
class="t3js-icon icon icon-size-small icon-state-default icon-actions-system-shortcut-new"
data-identifier="actions-system-shortcut-new" aria-hidden="true">
diff --git a/typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArgumentsCopyToClipboard.html b/typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArgumentsCopyToClipboard.html
index fa42fb1e6471..ec07e14647e6 100644
--- a/typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArgumentsCopyToClipboard.html
+++ b/typo3/sysext/backend/Tests/Functional/Template/Fixtures/SpecialRouteIdentifierWithArgumentsCopyToClipboard.html
@@ -19,9 +19,9 @@
<li>
<button
data-dispatch-action="TYPO3.ShortcutMenu.createShortcut"
- data-dispatch-args="[&quot;record_edit&quot;,&quot;{\u0022id\u0022:123,\u0022edit\u0022:{\u0022pages\u0022:{\u0022123\u0022:\u0022edit\u0022},\u0022overrideVals\u0022:{\u0022pages\u0022:{\u0022sys_language_uid\u0022:1}}}}&quot;,&quot;Edit record&quot;,&quot;Create a bookmark to this page&quot;,&quot;{$target}&quot;]"
+ data-dispatch-args="[&quot;record_edit&quot;,&quot;{\u0022id\u0022:123,\u0022edit\u0022:{\u0022pages\u0022:{\u0022123\u0022:\u0022edit\u0022},\u0022overrideVals\u0022:{\u0022pages\u0022:{\u0022sys_language_uid\u0022:1}}}}&quot;,&quot;Edit record&quot;,&quot;Create a bookmark to this record&quot;,&quot;{$target}&quot;]"
class="dropdown-item dropdown-item-spaced"
- title="Create a bookmark to this page">
+ title="Create a bookmark to this record">
<span
class="t3js-icon icon icon-size-small icon-state-default icon-actions-system-shortcut-new"
data-identifier="actions-system-shortcut-new" aria-hidden="true">
@@ -30,14 +30,14 @@
<use xlink:href="typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/actions.svg#actions-star" />
</svg>
</span>
- </span>Create a bookmark to this page
+ </span>Create a bookmark to this record
</button>
</li>
<li>
<typo3-copy-to-clipboard
text="http://example.com/typo3/record/edit?id=123&edit%5Bpages%5D%5B123%5D=edit&edit%5BoverrideVals%5D%5Bpages%5D%5Bsys_language_uid%5D=1"
class="dropdown-item dropdown-item-spaced"
- title="Copy URL of this page">
+ title="Copy URL of this record">
<span
class="t3js-icon icon icon-size-small icon-state-default icon-actions-link"
data-identifier="actions-link" aria-hidden="true">
@@ -46,7 +46,7 @@
<use xlink:href="typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/actions.svg#actions-link" />
</svg>
</span>
- </span>Copy URL of this page
+ </span>Copy URL of this record
</typo3-copy-to-clipboard>
</li>
</ul>
diff --git a/typo3/sysext/core/Resources/Private/Language/locallang_core.xlf b/typo3/sysext/core/Resources/Private/Language/locallang_core.xlf
index 9cf56d5f2f20..b51b5ef4bf33 100644
--- a/typo3/sysext/core/Resources/Private/Language/locallang_core.xlf
+++ b/typo3/sysext/core/Resources/Private/Language/locallang_core.xlf
@@ -16,13 +16,13 @@
<source>Create a shortcut to this page?</source>
</trans-unit>
<trans-unit id="labels.makeBookmark" resname="labels.makeBookmark">
- <source>Create a bookmark to this page</source>
+ <source>Create a bookmark to this record</source>
</trans-unit>
<trans-unit id="labels.alreadyBookmarked" resname="labels.alreadyBookmarked">
- <source>This page is already bookmarked</source>
+ <source>This record is already bookmarked</source>
</trans-unit>
<trans-unit id="labels.copyCurrentUrl" resname="labels.copyCurrentUrl">
- <source>Copy URL of this page</source>
+ <source>Copy URL of this record</source>
</trans-unit>
<trans-unit id="labels.lockedRecord" resname="labels.lockedRecord">
<source>The user '%s' began to edit this record %s ago.</source>
--
GitLab