diff --git a/Build/phpstan.level3.neon b/Build/phpstan.level3.neon index e5f9b3234e0b59592dcf614fb8c1be93be632f65..d07dd93948d2bc2ebf6b76698a45ebccc2c47dce 100644 --- a/Build/phpstan.level3.neon +++ b/Build/phpstan.level3.neon @@ -13,7 +13,7 @@ rules: - PHPStan\Rules\Functions\ReturnTypeRule - PHPStan\Rules\Generators\YieldTypeRule # - PHPStan\Rules\Methods\ReturnTypeRule -# - PHPStan\Rules\Properties\DefaultValueTypesAssignedToPropertiesRule + - PHPStan\Rules\Properties\DefaultValueTypesAssignedToPropertiesRule # - PHPStan\Rules\Properties\TypesAssignedToPropertiesRule - PHPStan\Rules\Variables\ThrowTypeRule - PHPStan\Rules\Variables\VariableCloningRule diff --git a/typo3/sysext/backend/Classes/Controller/EditDocumentController.php b/typo3/sysext/backend/Classes/Controller/EditDocumentController.php index f745cdad984ac13fde3cf7c9651893677ddab237..d8d044812984c479fed69450d5b9dbfbe97729d7 100644 --- a/typo3/sysext/backend/Classes/Controller/EditDocumentController.php +++ b/typo3/sysext/backend/Classes/Controller/EditDocumentController.php @@ -345,7 +345,7 @@ class EditDocumentController /** * Used internally to disable the storage of the document reference (eg. new records) * - * @var bool + * @var int */ protected $dontStoreDocumentRef = 0; diff --git a/typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php b/typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php index ec2870658fc38dd1dd1f42ff83f47433fe5f242b..328a2104526eef61d60a0091adbebb648c720188 100644 --- a/typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php +++ b/typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php @@ -92,7 +92,7 @@ abstract class AbstractTreeView * Needs to be initialized with $GLOBALS['BE_USER'] * Done by default in init() * - * @var \TYPO3\CMS\Core\Authentication\BackendUserAuthentication + * @var \TYPO3\CMS\Core\Authentication\BackendUserAuthentication|string */ public $BE_USER = ''; diff --git a/typo3/sysext/backend/Classes/Tree/View/ContentCreationPagePositionMap.php b/typo3/sysext/backend/Classes/Tree/View/ContentCreationPagePositionMap.php index 34b983e57b108207b26ec0d567c6de8b7e9ecb9b..91e41e7b6450721475788479da985555d946e7b6 100644 --- a/typo3/sysext/backend/Classes/Tree/View/ContentCreationPagePositionMap.php +++ b/typo3/sysext/backend/Classes/Tree/View/ContentCreationPagePositionMap.php @@ -25,7 +25,7 @@ use TYPO3\CMS\Core\Utility\GeneralUtility; class ContentCreationPagePositionMap extends PagePositionMap { /** - * @var bool + * @var int */ public $dontPrintPageInsertIcons = 1; diff --git a/typo3/sysext/backend/Classes/View/BackendLayout/BackendLayout.php b/typo3/sysext/backend/Classes/View/BackendLayout/BackendLayout.php index 053273c9cfc49b5cf447b6cc29fe0560d46995d7..e317fcb65b88942d03e450c0b2341f70e575a225 100644 --- a/typo3/sysext/backend/Classes/View/BackendLayout/BackendLayout.php +++ b/typo3/sysext/backend/Classes/View/BackendLayout/BackendLayout.php @@ -77,7 +77,7 @@ class BackendLayout protected $contentFetcher; /** - * @var LanguageColumn + * @var LanguageColumn[] */ protected $languageColumns = []; diff --git a/typo3/sysext/belog/Classes/Domain/Model/LogEntry.php b/typo3/sysext/belog/Classes/Domain/Model/LogEntry.php index 7115b8f9ed40d9c45b04c067f8380ce24e36a246..937acc34bb9c57dc86de24bcb8c087622b65d142 100644 --- a/typo3/sysext/belog/Classes/Domain/Model/LogEntry.php +++ b/typo3/sysext/belog/Classes/Domain/Model/LogEntry.php @@ -58,7 +58,7 @@ class LogEntry extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity /** * Table name * - * @var string + * @var string|int */ protected $tableName = 0; @@ -135,7 +135,7 @@ class LogEntry extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity /** * New ID * - * @var string + * @var string|int */ protected $newId = 0; diff --git a/typo3/sysext/core/Classes/DataHandling/DataHandler.php b/typo3/sysext/core/Classes/DataHandling/DataHandler.php index 66c7f7b32515a64b9697cbb441c4c9bc7cc6cd37..2a31af7018d23b20be607d668ce641c68c4b15d7 100644 --- a/typo3/sysext/core/Classes/DataHandling/DataHandler.php +++ b/typo3/sysext/core/Classes/DataHandling/DataHandler.php @@ -557,7 +557,7 @@ class DataHandler implements LoggerAwareInterface * Tells, that this DataHandler instance was called from \TYPO3\CMS\Impext\ImportExport. * This variable is set by \TYPO3\CMS\Impext\ImportExport * - * @var array + * @var bool */ public $callFromImpExp = false; diff --git a/typo3/sysext/core/Classes/Database/Query/Restriction/DefaultRestrictionContainer.php b/typo3/sysext/core/Classes/Database/Query/Restriction/DefaultRestrictionContainer.php index 3fa0808b3df20f2de7ff2f954c5b22907d44e92c..7d249dc7aa9bc25789b91a77dc348397352b3c7a 100644 --- a/typo3/sysext/core/Classes/Database/Query/Restriction/DefaultRestrictionContainer.php +++ b/typo3/sysext/core/Classes/Database/Query/Restriction/DefaultRestrictionContainer.php @@ -23,7 +23,7 @@ class DefaultRestrictionContainer extends AbstractRestrictionContainer /** * Default restriction classes. * - * @var QueryRestrictionInterface[] + * @var string[] */ protected $defaultRestrictionTypes = [ DeletedRestriction::class, diff --git a/typo3/sysext/core/Classes/Database/Query/Restriction/FrontendRestrictionContainer.php b/typo3/sysext/core/Classes/Database/Query/Restriction/FrontendRestrictionContainer.php index bcfbedaf0c1c9c908148af96c1d4d75621b78a54..2f918969271da6499e4a6da5d2a9512ac6d7c7d8 100644 --- a/typo3/sysext/core/Classes/Database/Query/Restriction/FrontendRestrictionContainer.php +++ b/typo3/sysext/core/Classes/Database/Query/Restriction/FrontendRestrictionContainer.php @@ -28,7 +28,7 @@ use TYPO3\CMS\Core\Utility\GeneralUtility; class FrontendRestrictionContainer extends AbstractRestrictionContainer { /** - * @var QueryRestrictionInterface[] + * @var string[] */ protected $defaultRestrictionTypes = [ DeletedRestriction::class, diff --git a/typo3/sysext/core/Classes/Messaging/Renderer/BootstrapRenderer.php b/typo3/sysext/core/Classes/Messaging/Renderer/BootstrapRenderer.php index d58edb32e91b7f76a5f5157ecd2c1693098e8b02..d0166f9785794ccda0e93541015da5a24f2cd9ba 100644 --- a/typo3/sysext/core/Classes/Messaging/Renderer/BootstrapRenderer.php +++ b/typo3/sysext/core/Classes/Messaging/Renderer/BootstrapRenderer.php @@ -27,7 +27,7 @@ use TYPO3\CMS\Core\Messaging\FlashMessage; class BootstrapRenderer implements FlashMessageRendererInterface { /** - * @var string The message severity class names + * @var string[] The message severity class names */ protected static $classes = [ FlashMessage::NOTICE => 'notice', @@ -38,7 +38,7 @@ class BootstrapRenderer implements FlashMessageRendererInterface ]; /** - * @var string The message severity icon names + * @var string[] The message severity icon names */ protected static $icons = [ FlashMessage::NOTICE => 'lightbulb-o', diff --git a/typo3/sysext/core/Classes/Messaging/Renderer/ListRenderer.php b/typo3/sysext/core/Classes/Messaging/Renderer/ListRenderer.php index afc66508a037b178aa4d414210b35b92c15a2be9..319c25276d3ff96b2b64a4433c95496e981ddc77 100644 --- a/typo3/sysext/core/Classes/Messaging/Renderer/ListRenderer.php +++ b/typo3/sysext/core/Classes/Messaging/Renderer/ListRenderer.php @@ -28,7 +28,7 @@ use TYPO3\CMS\Core\Messaging\FlashMessage; class ListRenderer implements FlashMessageRendererInterface { /** - * @var string The message severity class names + * @var string[] The message severity class names */ protected static $classes = [ FlashMessage::NOTICE => 'notice', @@ -39,7 +39,7 @@ class ListRenderer implements FlashMessageRendererInterface ]; /** - * @var string The message severity icon names + * @var string[] The message severity icon names */ protected static $icons = [ FlashMessage::NOTICE => 'lightbulb-o', diff --git a/typo3/sysext/extbase/Classes/Persistence/Generic/Query.php b/typo3/sysext/extbase/Classes/Persistence/Generic/Query.php index 5f2ba930f62914f3e2becbf9835c5b6fb88729a5..c58746e2186994c1c312ffffc1a391ad2036a355 100644 --- a/typo3/sysext/extbase/Classes/Persistence/Generic/Query.php +++ b/typo3/sysext/extbase/Classes/Persistence/Generic/Query.php @@ -82,7 +82,7 @@ class Query implements QueryInterface protected $statement; /** - * @var int + * @var int[] */ protected $orderings = []; diff --git a/typo3/sysext/extbase/Classes/Validation/Error.php b/typo3/sysext/extbase/Classes/Validation/Error.php index ce9b670f57259fbb2070e313f79ec089cad9c847..203f3cfc665e9eb7692cf1d165e8db6cf9f9e7e8 100644 --- a/typo3/sysext/extbase/Classes/Validation/Error.php +++ b/typo3/sysext/extbase/Classes/Validation/Error.php @@ -25,7 +25,7 @@ class Error extends \TYPO3\CMS\Extbase\Error\Error protected $message = 'Unknown validation error'; /** - * @var string + * @var int */ protected $code = 1201447005; } diff --git a/typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php b/typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php index 4345e99289960dcae2523f9a961b9f1494c254b6..5c228c1abf106b97481ff5d64081a68298858c79 100644 --- a/typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php +++ b/typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php @@ -47,7 +47,7 @@ class DownloadController extends AbstractController protected $downloadUtility; /** - * @var JsonView + * @var string */ protected $defaultViewObjectName = JsonView::class; diff --git a/typo3/sysext/extensionmanager/Classes/Controller/UpdateFromTerController.php b/typo3/sysext/extensionmanager/Classes/Controller/UpdateFromTerController.php index be9179494cf9bad330eca7a5e89d863fcb447935..cdc562363270f7d68dcb4eb92a60c479c824b441 100644 --- a/typo3/sysext/extensionmanager/Classes/Controller/UpdateFromTerController.php +++ b/typo3/sysext/extensionmanager/Classes/Controller/UpdateFromTerController.php @@ -48,7 +48,7 @@ class UpdateFromTerController extends AbstractController protected $extensionRepository; /** - * @var JsonView + * @var string */ protected $defaultViewObjectName = JsonView::class; diff --git a/typo3/sysext/filelist/Classes/Controller/FileListController.php b/typo3/sysext/filelist/Classes/Controller/FileListController.php index d8a82ca6ca1ceb986da8cb5909be062b4402ec85..a90ec95839a4168471b05d797051138a256066ad 100644 --- a/typo3/sysext/filelist/Classes/Controller/FileListController.php +++ b/typo3/sysext/filelist/Classes/Controller/FileListController.php @@ -137,7 +137,7 @@ class FileListController extends ActionController implements LoggerAwareInterfac /** * BackendTemplateView Container * - * @var BackendTemplateView + * @var string */ protected $defaultViewObjectName = BackendTemplateView::class; diff --git a/typo3/sysext/form/Classes/Controller/FormEditorController.php b/typo3/sysext/form/Classes/Controller/FormEditorController.php index eac1ee2a292cfe09d1a72cbe3fdf786adf58dfea..9dd18dd8dc22a4959b2e53110a68e6a352bacb2e 100644 --- a/typo3/sysext/form/Classes/Controller/FormEditorController.php +++ b/typo3/sysext/form/Classes/Controller/FormEditorController.php @@ -53,7 +53,7 @@ class FormEditorController extends AbstractBackendController /** * Default View Container * - * @var BackendTemplateView + * @var string */ protected $defaultViewObjectName = BackendTemplateView::class; diff --git a/typo3/sysext/form/Classes/Controller/FormManagerController.php b/typo3/sysext/form/Classes/Controller/FormManagerController.php index 6ec0ebe3d49c38bac2c4927db825915225cc2396..a1413f426280ac8bcf8ee7e7859995fa3e248559 100644 --- a/typo3/sysext/form/Classes/Controller/FormManagerController.php +++ b/typo3/sysext/form/Classes/Controller/FormManagerController.php @@ -60,7 +60,7 @@ class FormManagerController extends AbstractBackendController /** * Default View Container * - * @var BackendTemplateView + * @var string */ protected $defaultViewObjectName = BackendTemplateView::class; diff --git a/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php b/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php index 7056f9605197e715b04bda30f5f8e24d8673c815..388300642c4273b48c90b42351cccb2d4233c5d9 100644 --- a/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php +++ b/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php @@ -113,7 +113,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface /** * The type (read-only) - * @var int + * @var int|string */ public $type = ''; @@ -189,7 +189,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface /** * sys_page-object, pagefunctions * - * @var PageRepository + * @var PageRepository|string */ public $sys_page = ''; @@ -223,7 +223,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface /** * The frontend user * - * @var FrontendUserAuthentication + * @var FrontendUserAuthentication|string */ public $fe_user = ''; @@ -318,7 +318,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface /** * TypoScript configuration of the page-object pointed to by sPre. * $this->tmpl->setup[$this->sPre.'.'] - * @var array + * @var array|string */ public $pSetup = ''; @@ -357,7 +357,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface /** * May be set to the pagesTSconfig - * @var array + * @var array|string * @internal */ protected $pagesTSconfig = ''; @@ -399,7 +399,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface public $additionalCSS = []; /** - * @var string + * @var string */ public $JSCode; @@ -593,7 +593,7 @@ class TypoScriptFrontendController implements LoggerAwareInterface /** * Page content render object * - * @var ContentObjectRenderer + * @var ContentObjectRenderer|string */ public $cObj = ''; diff --git a/typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php b/typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php index 52b75c847254663779d99341a54fb271ecd055fe..874375b8b58aa8580d6f1f5c816d16f37b086885 100644 --- a/typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php +++ b/typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php @@ -70,7 +70,7 @@ class AdministrationController extends ActionController /** * Backend Template Container * - * @var BackendTemplateView + * @var string */ protected $defaultViewObjectName = BackendTemplateView::class; diff --git a/typo3/sysext/install/Classes/FolderStructure/DirectoryNode.php b/typo3/sysext/install/Classes/FolderStructure/DirectoryNode.php index 75a36413eaf8c5f62f8c5a240902b1a608ba21f4..7ffa0b2c780681e91699549ff303169f98f764e2 100644 --- a/typo3/sysext/install/Classes/FolderStructure/DirectoryNode.php +++ b/typo3/sysext/install/Classes/FolderStructure/DirectoryNode.php @@ -24,7 +24,7 @@ use TYPO3\CMS\Core\Utility\StringUtility; class DirectoryNode extends AbstractNode implements NodeInterface { /** - * @var int|null Default for directories is octal 02775 == decimal 1533 + * @var string Default for directories is octal 02775 == decimal 1533 */ protected $targetPermission = '2775'; diff --git a/typo3/sysext/install/Classes/FolderStructure/FileNode.php b/typo3/sysext/install/Classes/FolderStructure/FileNode.php index 1fab25aaf3e0bed1796733590bf90ddc6b45f1e5..1e299eb48691cce41537f3905e0ea794cd5d53f2 100644 --- a/typo3/sysext/install/Classes/FolderStructure/FileNode.php +++ b/typo3/sysext/install/Classes/FolderStructure/FileNode.php @@ -23,7 +23,7 @@ use TYPO3\CMS\Core\Messaging\FlashMessage; class FileNode extends AbstractNode implements NodeInterface { /** - * @var int|null Default for files is octal 0664 == decimal 436 + * @var string Default for files is octal 0664 == decimal 436 */ protected $targetPermission = '0664'; diff --git a/typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php b/typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php index 663221eee4b06574347fd22b183be89df2f1becd..0703c29420158beaefa3ae91875d9a1e97241822 100644 --- a/typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php +++ b/typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php @@ -54,7 +54,7 @@ class ExternalLinktype extends AbstractLinktype * Preferred method of fetching (HEAD | GET). * If HEAD is used, we fallback to GET * - * @var array + * @var string */ protected $method = 'HEAD'; diff --git a/typo3/sysext/redirects/Classes/Service/SlugService.php b/typo3/sysext/redirects/Classes/Service/SlugService.php index e7e4dbc7c2a89984ee9cdb92f33793cb325f6b26..e6c81a73128e53daf69790d63fc7521c2d2e6767 100644 --- a/typo3/sysext/redirects/Classes/Service/SlugService.php +++ b/typo3/sysext/redirects/Classes/Service/SlugService.php @@ -75,12 +75,12 @@ class SlugService implements LoggerAwareInterface protected $pageRepository; /** - * @var CorrelationId + * @var CorrelationId|string */ protected $correlationIdRedirectCreation = ''; /** - * @var CorrelationId + * @var CorrelationId|string */ protected $correlationIdSlugUpdate = '';