From 541dce4149860b508e5039c517cf0ff5957cd54f Mon Sep 17 00:00:00 2001
From: Oliver Klee <typo3-coding@oliverklee.de>
Date: Fri, 18 Nov 2022 09:42:09 +0100
Subject: [PATCH] [BUGFIX] Do not mark the FAL-related Extbase models as
internal anymore
The FAL-related Extbase models are documented in the "TYPO3 Explained"
documentation, and they are the recommended way to use FAL in an
Extbase context. So the following classes are not marked as `@internal`
anymore in order to not send mixed signals to extension developers:
- TYPO3\CMS\Extbase\Domain\Model\File
- TYPO3\CMS\Extbase\Domain\Model\FileReference
- TYPO3\CMS\Extbase\Domain\Model\Folder
There is no point in forcing extension authors to re-implement
those classes (and duplicating the code from the Core) when
the Core implementation is stable now and has proven to
work fine.
Some history for what has happened:
Those classes started out marked as experimental (when they were
indeed still experimental). Then, in a cleanup bulk change in
3888dae8f3f71c3f5e1db1c00bcbfe7d0d8fed2e5966e6533c9353b6d7485f32,
the classes were converted to use the `@internal` annotation,
even though at least the three FAL Extbase models should have
been made public API instead by that time.
This is where the usage of the FAL models is documented in
"TYPO3 Explained":
https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Fal/UsingFal/Frontend.html
Resolves: #99126
Releases: main, 11.5
Change-Id: I2935fdb989569c7fc4088975af0ba1e5206df6d2
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76670
Tested-by: core-ci <typo3@b13.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Lina Wolf <112@linawolf.de>
Reviewed-by: Lina Wolf <112@linawolf.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
---
typo3/sysext/extbase/Classes/Domain/Model/File.php | 2 --
typo3/sysext/extbase/Classes/Domain/Model/FileReference.php | 2 --
typo3/sysext/extbase/Classes/Domain/Model/Folder.php | 2 --
3 files changed, 6 deletions(-)
diff --git a/typo3/sysext/extbase/Classes/Domain/Model/File.php b/typo3/sysext/extbase/Classes/Domain/Model/File.php
index 1326c74b5402..2fba08c22f69 100644
--- a/typo3/sysext/extbase/Classes/Domain/Model/File.php
+++ b/typo3/sysext/extbase/Classes/Domain/Model/File.php
@@ -20,8 +20,6 @@ use TYPO3\CMS\Core\Utility\GeneralUtility;
/**
* A file object (File Abstraction Layer)
- *
- * @internal
*/
class File extends AbstractFileFolder
{
diff --git a/typo3/sysext/extbase/Classes/Domain/Model/FileReference.php b/typo3/sysext/extbase/Classes/Domain/Model/FileReference.php
index cea32c3742e2..1af02ab28ec3 100644
--- a/typo3/sysext/extbase/Classes/Domain/Model/FileReference.php
+++ b/typo3/sysext/extbase/Classes/Domain/Model/FileReference.php
@@ -21,8 +21,6 @@ use TYPO3\CMS\Core\Utility\GeneralUtility;
/**
* A file reference object (File Abstraction Layer)
- *
- * @internal
*/
class FileReference extends AbstractFileFolder
{
diff --git a/typo3/sysext/extbase/Classes/Domain/Model/Folder.php b/typo3/sysext/extbase/Classes/Domain/Model/Folder.php
index ceff466cf1b6..6cfeee621c8f 100644
--- a/typo3/sysext/extbase/Classes/Domain/Model/Folder.php
+++ b/typo3/sysext/extbase/Classes/Domain/Model/Folder.php
@@ -17,8 +17,6 @@ namespace TYPO3\CMS\Extbase\Domain\Model;
/**
* A folder object (File Abstraction Layer)
- *
- * @internal
*/
class Folder extends AbstractFileFolder
{
--
GitLab