From 52656b54473dc418808b2644d1d1b37a8ac14686 Mon Sep 17 00:00:00 2001
From: Helmut Hummel <typo3@helhum.io>
Date: Tue, 14 Mar 2023 16:41:20 +0700
Subject: [PATCH] [TASK] Lift type restriction in CommandApplication
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Instead of requiring strictly the TYPO3 implementation of a console Application,
the property is allowed to hold an instance of the base application class.
Releases: main
Resolves: #100160
Change-Id: I40934ac7a5534f211021b0ab331ca9903a307243
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78116
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
---
typo3/sysext/core/Classes/Console/CommandApplication.php | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/typo3/sysext/core/Classes/Console/CommandApplication.php b/typo3/sysext/core/Classes/Console/CommandApplication.php
index 55dcb9c08165..1c1f0a88dff2 100644
--- a/typo3/sysext/core/Classes/Console/CommandApplication.php
+++ b/typo3/sysext/core/Classes/Console/CommandApplication.php
@@ -15,6 +15,7 @@
namespace TYPO3\CMS\Core\Console;
+use Symfony\Component\Console\Application as SymfonyConsoleApplication;
use Symfony\Component\Console\Exception\ExceptionInterface;
use Symfony\Component\Console\Input\ArgvInput;
use Symfony\Component\Console\Output\ConsoleOutput;
@@ -49,7 +50,7 @@ class CommandApplication implements ApplicationInterface
protected LanguageServiceFactory $languageServiceFactory;
- protected Application $application;
+ protected SymfonyConsoleApplication $application;
public function __construct(
Context $context,
--
GitLab