From 4efdc1aa2509ba4ee76831e6c3096af83e3afb57 Mon Sep 17 00:00:00 2001
From: Oliver Klee <typo3-coding@oliverklee.de>
Date: Fri, 14 Oct 2022 10:40:50 +0200
Subject: [PATCH] [TASK] Update to PHPStan 1.8.9
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This update gets rid of some false positives.
Run commands:
> composer req --dev phpstan/phpstan:^1.8.9
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline
Resolves: #98610
Releases: main, 11.5
Change-Id: I65425faaf3c9b0f08bacb6fa56e60b97ca905ed1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76116
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
---
Build/phpstan/phpstan-baseline.neon | 10 ----------
composer.json | 2 +-
composer.lock | 16 ++++++++--------
3 files changed, 9 insertions(+), 19 deletions(-)
diff --git a/Build/phpstan/phpstan-baseline.neon b/Build/phpstan/phpstan-baseline.neon
index 04bef654ad7f..14df9872d402 100644
--- a/Build/phpstan/phpstan-baseline.neon
+++ b/Build/phpstan/phpstan-baseline.neon
@@ -5210,21 +5210,11 @@ parameters:
count: 1
path: ../../typo3/sysext/scheduler/Classes/CronCommand/NormalizeCommand.php
- -
- message: "#^Result of && is always false\\.$#"
- count: 1
- path: ../../typo3/sysext/scheduler/Classes/CronCommand/NormalizeCommand.php
-
-
message: "#^Strict comparison using \\=\\=\\= between non\\-falsy\\-string and '' will always evaluate to false\\.$#"
count: 1
path: ../../typo3/sysext/scheduler/Classes/CronCommand/NormalizeCommand.php
- -
- message: "#^Strict comparison using \\=\\=\\= between non\\-falsy\\-string and '0' will always evaluate to false\\.$#"
- count: 1
- path: ../../typo3/sysext/scheduler/Classes/CronCommand/NormalizeCommand.php
-
-
message: "#^Parameter \\#1 \\$id of method TYPO3\\\\CMS\\\\Scheduler\\\\Task\\\\AbstractTask\\:\\:setTaskUid\\(\\) expects int, string given\\.$#"
count: 1
diff --git a/composer.json b/composer.json
index a30ac926b79b..9405720f49e4 100644
--- a/composer.json
+++ b/composer.json
@@ -117,7 +117,7 @@
"php-webdriver/webdriver": "^1.12.0",
"phpspec/prophecy": "^1.15.0",
"phpspec/prophecy-phpunit": "^2.0.1",
- "phpstan/phpstan": "^1.8.8",
+ "phpstan/phpstan": "^1.8.9",
"phpstan/phpstan-phpunit": "^1.1.1",
"phpunit/phpunit": "^9.5.21",
"typo3/cms-styleguide": "~11.5.4",
diff --git a/composer.lock b/composer.lock
index 986d7a16c447..f3de58521bd2 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
"Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
"This file is @generated automatically"
],
- "content-hash": "d006be59871e90bb25eaad09d3586079",
+ "content-hash": "68d3dbe0a93300ec555342daa2e7ec64",
"packages": [
{
"name": "bacon/bacon-qr-code",
@@ -7095,16 +7095,16 @@
},
{
"name": "phpstan/phpstan",
- "version": "1.8.8",
+ "version": "1.8.9",
"source": {
"type": "git",
"url": "https://github.com/phpstan/phpstan.git",
- "reference": "08310ce271984587e2a4cda94e1ac66510a6ea07"
+ "reference": "3a72d9d9f2528fbd50c2d8fcf155fd9f74ade3f2"
},
"dist": {
"type": "zip",
- "url": "https://api.github.com/repos/phpstan/phpstan/zipball/08310ce271984587e2a4cda94e1ac66510a6ea07",
- "reference": "08310ce271984587e2a4cda94e1ac66510a6ea07",
+ "url": "https://api.github.com/repos/phpstan/phpstan/zipball/3a72d9d9f2528fbd50c2d8fcf155fd9f74ade3f2",
+ "reference": "3a72d9d9f2528fbd50c2d8fcf155fd9f74ade3f2",
"shasum": ""
},
"require": {
@@ -7134,7 +7134,7 @@
],
"support": {
"issues": "https://github.com/phpstan/phpstan/issues",
- "source": "https://github.com/phpstan/phpstan/tree/1.8.8"
+ "source": "https://github.com/phpstan/phpstan/tree/1.8.9"
},
"funding": [
{
@@ -7150,7 +7150,7 @@
"type": "tidelift"
}
],
- "time": "2022-10-06T12:51:57+00:00"
+ "time": "2022-10-13T13:40:18+00:00"
},
{
"name": "phpstan/phpstan-phpunit",
@@ -9181,5 +9181,5 @@
"platform-overrides": {
"php": "7.4.1"
},
- "plugin-api-version": "2.3.0"
+ "plugin-api-version": "2.2.0"
}
--
GitLab