From 4ec39adf5e89c12501cb06eab059eb6939eef662 Mon Sep 17 00:00:00 2001
From: Susanne Moog <look@susi.dev>
Date: Fri, 6 Mar 2020 17:56:00 +0100
Subject: [PATCH] [BUGFIX] Display error messages in scheduler
The scheduler exception handling on editing silently ignored most
exceptions. The one exception was a specific exception that did not
even exist anymore.
The handling was changed to only ignore those exceptions with existing
handling and adding messages for all others.
Resolves: #80299
Releases: master, 9.5
Change-Id: I9b2a91f244bec99deb79da93a4e33680e862d16c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63568
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
---
.../Controller/SchedulerModuleController.php | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php b/typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php
index fce32842c577..fc5a127e3dce 100644
--- a/typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php
+++ b/typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php
@@ -279,15 +279,13 @@ class SchedulerModuleController
// Try adding or editing
$content .= $this->editTaskAction();
$sectionTitle = $this->getLanguageService()->getLL('action.' . $this->getCurrentAction());
+ } catch (\LogicException|\UnexpectedValueException|\OutOfBoundsException $e) {
+ // Catching all types of exceptions that were previously handled and
+ // converted to messages
+ $content .= $this->listTasksAction();
} catch (\Exception $e) {
- if ($e->getCode() === 1305100019) {
- // Invalid controller class name exception
- $this->addMessage($e->getMessage(), FlashMessage::ERROR);
- }
- // An exception may also happen when the task to
- // edit could not be found. In this case revert
- // to displaying the list of tasks
- // It can also happen when attempting to edit a running task
+ // Catching all "unexpected" exceptions not previously handled
+ $this->addMessage($e->getMessage(), FlashMessage::ERROR);
$content .= $this->listTasksAction();
}
break;
--
GitLab