From 4c0c7524150ccbb20d5bf6fae0b3a236b55cdc72 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Frank=20N=C3=A4gler?= <typo3@naegler.net>
Date: Mon, 29 Jun 2015 18:31:17 +0200
Subject: [PATCH] [!!!][TASK] Remove tceforms.js because we don't need it
anymore
The IE code for ValueSlider is not needed anymore, also the QuickTips not
used within FormEngine.
Resolves: #67815
Releases: master
Change-Id: I9919dc1350271281ece6aa8767fb8c375205e906
Reviewed-on: http://review.typo3.org/40726
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
---
.../backend/Classes/Form/FormEngine.php | 1 -
.../Resources/Public/JavaScript/tceforms.js | 41 -------------------
...veTceformsjsBecauseWeDontNeedItAnymore.rst | 26 ++++++++++++
3 files changed, 26 insertions(+), 42 deletions(-)
delete mode 100644 typo3/sysext/backend/Resources/Public/JavaScript/tceforms.js
create mode 100644 typo3/sysext/core/Documentation/Changelog/master/Breaking-67815-RemoveTceformsjsBecauseWeDontNeedItAnymore.rst
diff --git a/typo3/sysext/backend/Classes/Form/FormEngine.php b/typo3/sysext/backend/Classes/Form/FormEngine.php
index eac81266358c..565cc77be843 100644
--- a/typo3/sysext/backend/Classes/Form/FormEngine.php
+++ b/typo3/sysext/backend/Classes/Form/FormEngine.php
@@ -1266,7 +1266,6 @@ class FormEngine {
// @todo: remove scriptaclous once suggest & flex form foo is moved to RequireJS, see #55575
$pageRenderer->loadScriptaculous();
- $this->loadJavascriptLib('sysext/backend/Resources/Public/JavaScript/tceforms.js');
$this->loadJavascriptLib('sysext/backend/Resources/Public/JavaScript/jsfunc.tceforms_suggest.js');
$pageRenderer->loadRequireJsModule('TYPO3/CMS/Filelist/FileListLocalisation');
diff --git a/typo3/sysext/backend/Resources/Public/JavaScript/tceforms.js b/typo3/sysext/backend/Resources/Public/JavaScript/tceforms.js
deleted file mode 100644
index fb82f07493c5..000000000000
--- a/typo3/sysext/backend/Resources/Public/JavaScript/tceforms.js
+++ /dev/null
@@ -1,41 +0,0 @@
-/*
- * This file is part of the TYPO3 CMS project.
- *
- * It is free software; you can redistribute it and/or modify it under
- * the terms of the GNU General Public License, either version 2
- * of the License, or any later version.
- *
- * For the full copyright and license information, please read the
- * LICENSE.txt file that was distributed with this source code.
- *
- * The TYPO3 project - inspiring people to share!
- */
-
-Ext.onReady(function() {
- Ext.QuickTips.init();
-});
-
- // Fix for slider TCA control in IE9
-Ext.override(Ext.dd.DragTracker, {
- onMouseMove:function (e, target) {
- var isIE9 = Ext.isIE && (/msie 9/.test(navigator.userAgent.toLowerCase())) && document.documentMode != 6;
- if (this.active && Ext.isIE && !isIE9 && !e.browserEvent.button) {
- e.preventDefault();
- this.onMouseUp(e);
- return;
- }
- e.preventDefault();
- var xy = e.getXY(), s = this.startXY;
- this.lastXY = xy;
- if (!this.active) {
- if (Math.abs(s[0] - xy[0]) > this.tolerance || Math.abs(s[1] - xy[1]) > this.tolerance) {
- this.triggerStart(e);
- } else {
- return;
- }
- }
- this.fireEvent('mousemove', this, e);
- this.onDrag(e);
- this.fireEvent('drag', this, e);
- }
-});
\ No newline at end of file
diff --git a/typo3/sysext/core/Documentation/Changelog/master/Breaking-67815-RemoveTceformsjsBecauseWeDontNeedItAnymore.rst b/typo3/sysext/core/Documentation/Changelog/master/Breaking-67815-RemoveTceformsjsBecauseWeDontNeedItAnymore.rst
new file mode 100644
index 000000000000..57d37f187dae
--- /dev/null
+++ b/typo3/sysext/core/Documentation/Changelog/master/Breaking-67815-RemoveTceformsjsBecauseWeDontNeedItAnymore.rst
@@ -0,0 +1,26 @@
+======================================================================
+Breaking: #67815 - Remove tceforms.js because we don't need it anymore
+======================================================================
+
+Description
+===========
+
+Since the value slider is based on bootstrap, the last code from ``tceforms.js`` is not needed anymore.
+
+
+Impact
+======
+
+All instances which include ``sysext/backend/Resources/Public/JavaScript/tceforms.js`` will produce a 404 Not Found error.
+
+
+Affected Installations
+======================
+
+All instances which include ``sysext/backend/Resources/Public/JavaScript/tceforms.js``.
+
+
+Migration
+=========
+
+Remove all references to the file.
--
GitLab