From 472edc94729d61a4b2b86cf6cd170d2e5918beec Mon Sep 17 00:00:00 2001
From: Sascha Egerer <sascha@sascha-egerer.de>
Date: Sun, 17 Apr 2016 22:38:48 +0200
Subject: [PATCH] [BUGFIX] Cursor position is changed while typing
Fields in the backend are validated while typing. One validation
is the left space trim. Spaces on the left side are removed but
also the cursor position is changed. If you are a fast typer
this could end up in a mixed up input. The cursor position should
not be changed by the validation JavaScript.
Change-Id: I93e46dff763363eed193d41b1fd71fbe043fbcd8
Resolves: #75724
Related: #75626
Releases: master
Reviewed-on: https://review.typo3.org/47737
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
---
.../Public/JavaScript/FormEngineValidation.js | 26 +------------------
1 file changed, 1 insertion(+), 25 deletions(-)
diff --git a/typo3/sysext/backend/Resources/Public/JavaScript/FormEngineValidation.js b/typo3/sysext/backend/Resources/Public/JavaScript/FormEngineValidation.js
index ba6ba33442e4..8408d9014f78 100644
--- a/typo3/sysext/backend/Resources/Public/JavaScript/FormEngineValidation.js
+++ b/typo3/sysext/backend/Resources/Public/JavaScript/FormEngineValidation.js
@@ -521,36 +521,12 @@ define(['jquery', 'TYPO3/CMS/Backend/FormEngine'], function ($, FormEngine) {
modified = true;
}
if (modified) {
- $field.attr('value', newValue);
- FormEngineValidation.setCaretPosition($field, 0);
+ $field.val(newValue);
}
}
});
};
- /**
- * Set the caret position in a text field
- *
- * @param {Object} $element
- * @param {Number} caretPos
- */
- FormEngineValidation.setCaretPosition = function($element, caretPos) {
- var elem = $element.get(0);
-
- if (elem.createTextRange) {
- var range = elem.createTextRange();
- range.move('character', caretPos);
- range.select();
- } else {
- if (elem.selectionStart) {
- elem.focus();
- elem.setSelectionRange(caretPos, caretPos);
- } else {
- elem.focus();
- }
- }
- };
-
/**
* Helper function to get clean trimmed array from comma list
*
--
GitLab