From 44ce57e72e3481224f745ca6db8f0f15372cc104 Mon Sep 17 00:00:00 2001
From: Richard Haeser <richard@maxserv.com>
Date: Fri, 17 Apr 2020 17:10:26 +0200
Subject: [PATCH] [TASK] Mark non-public-API classes for Dashboard as internal

Most classes used in EXT:dashboard are internal classes and
are now marked as internal and therefor not part of the
public API.

Resolves: #91093
Releases: master
Change-Id: Idd9ccf423b6330908487fd1278163f51b64f50d3
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64216
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
---
 .../sysext/dashboard/Classes/Controller/AbstractController.php | 3 +++
 .../dashboard/Classes/Controller/DashboardController.php       | 3 +++
 .../dashboard/Classes/Controller/WidgetAjaxController.php      | 3 +++
 typo3/sysext/dashboard/Classes/Dashboard.php                   | 3 +++
 .../dashboard/Classes/DashboardInitializationService.php       | 3 +++
 typo3/sysext/dashboard/Classes/DashboardPreset.php             | 3 +++
 typo3/sysext/dashboard/Classes/DashboardPresetRegistry.php     | 3 +++
 typo3/sysext/dashboard/Classes/DashboardRepository.php         | 3 +++
 typo3/sysext/dashboard/Classes/Views/Factory.php               | 3 +++
 typo3/sysext/dashboard/Classes/WidgetGroup.php                 | 3 +++
 .../dashboard/Classes/WidgetGroupInitializationService.php     | 3 +++
 typo3/sysext/dashboard/Classes/WidgetGroupRegistry.php         | 3 +++
 typo3/sysext/dashboard/Classes/WidgetRegistry.php              | 3 +++
 13 files changed, 39 insertions(+)

diff --git a/typo3/sysext/dashboard/Classes/Controller/AbstractController.php b/typo3/sysext/dashboard/Classes/Controller/AbstractController.php
index 0d1c76a32c73..ef752f3670f4 100644
--- a/typo3/sysext/dashboard/Classes/Controller/AbstractController.php
+++ b/typo3/sysext/dashboard/Classes/Controller/AbstractController.php
@@ -20,6 +20,9 @@ namespace TYPO3\CMS\Dashboard\Controller;
 use TYPO3\CMS\Core\Authentication\BackendUserAuthentication;
 use TYPO3\CMS\Core\Localization\LanguageService;
 
+/**
+ * @internal
+ */
 class AbstractController
 {
     protected const MODULE_DATA_CURRENT_DASHBOARD_IDENTIFIER = 'dashboard/current_dashboard/';
diff --git a/typo3/sysext/dashboard/Classes/Controller/DashboardController.php b/typo3/sysext/dashboard/Classes/Controller/DashboardController.php
index 2c5ecb06cdb0..9b6b277095e7 100644
--- a/typo3/sysext/dashboard/Classes/Controller/DashboardController.php
+++ b/typo3/sysext/dashboard/Classes/Controller/DashboardController.php
@@ -36,6 +36,9 @@ use TYPO3\CMS\Dashboard\WidgetGroupInitializationService;
 use TYPO3\CMS\Extbase\Mvc\View\ViewInterface;
 use TYPO3\CMS\Fluid\View\StandaloneView;
 
+/**
+ * @internal
+ */
 class DashboardController extends AbstractController
 {
     /**
diff --git a/typo3/sysext/dashboard/Classes/Controller/WidgetAjaxController.php b/typo3/sysext/dashboard/Classes/Controller/WidgetAjaxController.php
index c2ac0d459668..a73afd90e44d 100644
--- a/typo3/sysext/dashboard/Classes/Controller/WidgetAjaxController.php
+++ b/typo3/sysext/dashboard/Classes/Controller/WidgetAjaxController.php
@@ -26,6 +26,9 @@ use TYPO3\CMS\Dashboard\WidgetRegistry;
 use TYPO3\CMS\Dashboard\Widgets\EventDataInterface;
 use TYPO3\CMS\Dashboard\Widgets\WidgetInterface;
 
+/**
+ * @internal
+ */
 class WidgetAjaxController extends AbstractController
 {
     /**
diff --git a/typo3/sysext/dashboard/Classes/Dashboard.php b/typo3/sysext/dashboard/Classes/Dashboard.php
index b2273f5f5c6a..f53089f5da8a 100644
--- a/typo3/sysext/dashboard/Classes/Dashboard.php
+++ b/typo3/sysext/dashboard/Classes/Dashboard.php
@@ -22,6 +22,9 @@ use TYPO3\CMS\Core\Localization\LanguageService;
 use TYPO3\CMS\Dashboard\Widgets\WidgetConfigurationInterface;
 use TYPO3\CMS\Dashboard\Widgets\WidgetInterface;
 
+/**
+ * @internal
+ */
 class Dashboard
 {
     /**
diff --git a/typo3/sysext/dashboard/Classes/DashboardInitializationService.php b/typo3/sysext/dashboard/Classes/DashboardInitializationService.php
index 3cc0895e0e5a..fe73282744e9 100644
--- a/typo3/sysext/dashboard/Classes/DashboardInitializationService.php
+++ b/typo3/sysext/dashboard/Classes/DashboardInitializationService.php
@@ -24,6 +24,9 @@ use TYPO3\CMS\Dashboard\Widgets\AdditionalCssInterface;
 use TYPO3\CMS\Dashboard\Widgets\AdditionalJavaScriptInterface;
 use TYPO3\CMS\Dashboard\Widgets\RequireJsModuleInterface;
 
+/**
+ * @internal
+ */
 class DashboardInitializationService
 {
     protected const MODULE_DATA_CURRENT_DASHBOARD_IDENTIFIER = 'dashboard/current_dashboard/';
diff --git a/typo3/sysext/dashboard/Classes/DashboardPreset.php b/typo3/sysext/dashboard/Classes/DashboardPreset.php
index db139a18d769..6003d2071eda 100644
--- a/typo3/sysext/dashboard/Classes/DashboardPreset.php
+++ b/typo3/sysext/dashboard/Classes/DashboardPreset.php
@@ -19,6 +19,9 @@ namespace TYPO3\CMS\Dashboard;
 
 use TYPO3\CMS\Core\Localization\LanguageService;
 
+/**
+ * @internal
+ */
 class DashboardPreset
 {
     /**
diff --git a/typo3/sysext/dashboard/Classes/DashboardPresetRegistry.php b/typo3/sysext/dashboard/Classes/DashboardPresetRegistry.php
index 0bcbd631aee1..5932d022b722 100644
--- a/typo3/sysext/dashboard/Classes/DashboardPresetRegistry.php
+++ b/typo3/sysext/dashboard/Classes/DashboardPresetRegistry.php
@@ -19,6 +19,9 @@ namespace TYPO3\CMS\Dashboard;
 
 use TYPO3\CMS\Core\SingletonInterface;
 
+/**
+ * @internal
+ */
 class DashboardPresetRegistry implements SingletonInterface
 {
     /**
diff --git a/typo3/sysext/dashboard/Classes/DashboardRepository.php b/typo3/sysext/dashboard/Classes/DashboardRepository.php
index 152ab41b461e..2e387c919ac0 100644
--- a/typo3/sysext/dashboard/Classes/DashboardRepository.php
+++ b/typo3/sysext/dashboard/Classes/DashboardRepository.php
@@ -24,6 +24,9 @@ use TYPO3\CMS\Core\Database\Query\QueryBuilder;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Dashboard\Widgets\WidgetInterface;
 
+/**
+ * @internal
+ */
 class DashboardRepository
 {
     private const TABLE = 'be_dashboards';
diff --git a/typo3/sysext/dashboard/Classes/Views/Factory.php b/typo3/sysext/dashboard/Classes/Views/Factory.php
index 7ad464fe3188..8d981d5ca008 100644
--- a/typo3/sysext/dashboard/Classes/Views/Factory.php
+++ b/typo3/sysext/dashboard/Classes/Views/Factory.php
@@ -20,6 +20,9 @@ namespace TYPO3\CMS\Dashboard\Views;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Fluid\View\StandaloneView;
 
+/**
+ * @internal
+ */
 class Factory
 {
     public static function widgetTemplate(): StandaloneView
diff --git a/typo3/sysext/dashboard/Classes/WidgetGroup.php b/typo3/sysext/dashboard/Classes/WidgetGroup.php
index 45e112ae520e..8be62b773619 100644
--- a/typo3/sysext/dashboard/Classes/WidgetGroup.php
+++ b/typo3/sysext/dashboard/Classes/WidgetGroup.php
@@ -19,6 +19,9 @@ namespace TYPO3\CMS\Dashboard;
 
 use TYPO3\CMS\Core\Localization\LanguageService;
 
+/**
+ * @internal
+ */
 class WidgetGroup
 {
     /**
diff --git a/typo3/sysext/dashboard/Classes/WidgetGroupInitializationService.php b/typo3/sysext/dashboard/Classes/WidgetGroupInitializationService.php
index 024c6d01b922..1ad9d6386878 100644
--- a/typo3/sysext/dashboard/Classes/WidgetGroupInitializationService.php
+++ b/typo3/sysext/dashboard/Classes/WidgetGroupInitializationService.php
@@ -19,6 +19,9 @@ namespace TYPO3\CMS\Dashboard;
 
 use TYPO3\CMS\Core\Localization\LanguageService;
 
+/**
+ * @internal
+ */
 class WidgetGroupInitializationService
 {
     /**
diff --git a/typo3/sysext/dashboard/Classes/WidgetGroupRegistry.php b/typo3/sysext/dashboard/Classes/WidgetGroupRegistry.php
index 191aed792ada..0de098cf735d 100644
--- a/typo3/sysext/dashboard/Classes/WidgetGroupRegistry.php
+++ b/typo3/sysext/dashboard/Classes/WidgetGroupRegistry.php
@@ -19,6 +19,9 @@ namespace TYPO3\CMS\Dashboard;
 
 use TYPO3\CMS\Core\SingletonInterface;
 
+/**
+ * @internal
+ */
 class WidgetGroupRegistry implements SingletonInterface
 {
     /**
diff --git a/typo3/sysext/dashboard/Classes/WidgetRegistry.php b/typo3/sysext/dashboard/Classes/WidgetRegistry.php
index d7ea59835fc2..915b33d02d48 100644
--- a/typo3/sysext/dashboard/Classes/WidgetRegistry.php
+++ b/typo3/sysext/dashboard/Classes/WidgetRegistry.php
@@ -23,6 +23,9 @@ use TYPO3\CMS\Core\SingletonInterface;
 use TYPO3\CMS\Core\Utility\ArrayUtility;
 use TYPO3\CMS\Dashboard\Widgets\WidgetInterface;
 
+/**
+ * @internal
+ */
 class WidgetRegistry implements SingletonInterface
 {
     /**
-- 
GitLab