From 4051828234d6df052ea99362e09c22f254c43352 Mon Sep 17 00:00:00 2001 From: Christian Kuhn <lolli@schwarzbu.ch> Date: Fri, 1 Dec 2017 11:50:40 +0100 Subject: [PATCH] [BUGFIX] Fix ExtJS removal documentation files A couple of syntax errors in the .rst files of the ExtJS / page tree feature. Resolves: #83185 Related: #82426 Releases: master Change-Id: I010dffddbe565de770868e717d75f16828d60b0b Reviewed-on: https://review.typo3.org/54897 Tested-by: TYPO3com <no-reply@typo3.com> Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by: Andreas Fernandez <typo3@scripting-base.de> Tested-by: Andreas Fernandez <typo3@scripting-base.de> --- ...-Typo3-pagetreeNavigationComponentName.rst | 5 +- ...NavigationModuleRegistrationEgPageTree.rst | 57 +++++++++---------- 2 files changed, 30 insertions(+), 32 deletions(-) diff --git a/typo3/sysext/core/Documentation/Changelog/master/Deprecation-82426-Typo3-pagetreeNavigationComponentName.rst b/typo3/sysext/core/Documentation/Changelog/master/Deprecation-82426-Typo3-pagetreeNavigationComponentName.rst index 890a51b2e96c..220c698b5beb 100644 --- a/typo3/sysext/core/Documentation/Changelog/master/Deprecation-82426-Typo3-pagetreeNavigationComponentName.rst +++ b/typo3/sysext/core/Documentation/Changelog/master/Deprecation-82426-Typo3-pagetreeNavigationComponentName.rst @@ -35,8 +35,7 @@ Use `TYPO3/CMS/Backend/PageTree/PageTreeElement` instead of `typo3-pagetree`. Old configuration: ------------------ - -.. code-block::php +.. code-block:: php \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule( 'TYPO3.CMS.Workspaces', @@ -60,7 +59,7 @@ Old configuration: Should be changed to new configuration: --------------------------------------- -.. code-block::php +.. code-block:: php \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule( 'TYPO3.CMS.Workspaces', diff --git a/typo3/sysext/core/Documentation/Changelog/master/Feature-82426-NewNavigationModuleRegistrationEgPageTree.rst b/typo3/sysext/core/Documentation/Changelog/master/Feature-82426-NewNavigationModuleRegistrationEgPageTree.rst index 77b4df5fd2e5..093915b3919a 100644 --- a/typo3/sysext/core/Documentation/Changelog/master/Feature-82426-NewNavigationModuleRegistrationEgPageTree.rst +++ b/typo3/sysext/core/Documentation/Changelog/master/Feature-82426-NewNavigationModuleRegistrationEgPageTree.rst @@ -9,38 +9,37 @@ See :issue:`82426` Description =========== -When registering an extensions's BE module with `ExtensionUtility::registerModule()` it is possible to define 'navigationComponentId'. +When registering an extensions's BE module with `ExtensionUtility::registerModule()` it is possible +to define 'navigationComponentId'. -Before the 'navigationComponentId' was used to pass a name of the ExtJS module registered with ExtensionManagementUtility::addNavigationComponent(). +Before, the 'navigationComponentId' has been used to pass a name of the ExtJS module registered with +ExtensionManagementUtility::addNavigationComponent(). -Now it should contain a RequireJS module name (no additional registration is necessary. -The TYPO3 page tree navigation component name 'typo3-pagetree' will still work (thanks to the BC layer) but will throw a deprecation notice. +Now it should contain a RequireJS module name. No additional registration is necessary. +The TYPO3 page tree navigation component name 'typo3-pagetree' will still work (thanks to the BC layer) +but will throw a deprecation notice. Should be changed to new configuration: -``` -\TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule( - 'TYPO3.CMS.Workspaces', - 'web', - 'workspaces', - 'before:info', - [ - // An array holding the controller-action-combinations that are accessible - 'Review' => 'index,fullIndex,singleIndex', - 'Preview' => 'index,newPage' - ], - [ - 'access' => 'user,group', - 'icon' => 'EXT:workspaces/Resources/Public/Icons/module-workspaces.svg', - 'labels' => 'LLL:EXT:workspaces/Resources/Private/Language/locallang_mod.xlf', - 'navigationComponentId' => 'TYPO3/CMS/Backend/PageTree/PageTreeElement' - ] -); -``` - - -Impact -====== - -impact + +.. code-block:: php + + \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule( + 'TYPO3.CMS.Workspaces', + 'web', + 'workspaces', + 'before:info', + [ + // An array holding the controller-action-combinations that are accessible + 'Review' => 'index,fullIndex,singleIndex', + 'Preview' => 'index,newPage' + ], + [ + 'access' => 'user,group', + 'icon' => 'EXT:workspaces/Resources/Public/Icons/module-workspaces.svg', + 'labels' => 'LLL:EXT:workspaces/Resources/Private/Language/locallang_mod.xlf', + 'navigationComponentId' => 'TYPO3/CMS/Backend/PageTree/PageTreeElement' + ] + ); + .. index:: Backend, JavaScript, PHP-API, NotScanned -- GitLab