From 3d171d0dc70158c8f089ac24b44bdc836822b8e6 Mon Sep 17 00:00:00 2001 From: Benjamin Franzke <ben@bnf.dev> Date: Tue, 10 Sep 2024 23:01:41 +0200 Subject: [PATCH] [BUGFIX] Fix detection of local settings in settings overview Site local settings (defined in the sites settings.yaml file) need to be taken into account in the site overview, only if they are based on definitions. Therefore the setting map (which is based on definitions) has to be evaluated instead of the flat settings map (which contains all settings, defined and legacy anonymous settings). Releases: main Resolves: #104886 Related: #104794 Change-Id: I49f8d01c3947302ff75a6aac0e3e64cdeca819c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85998 Tested-by: Oliver Bartsch <bo@cedev.de> Tested-by: core-ci <typo3@b13.com> Reviewed-by: Benjamin Franzke <ben@bnf.dev> Tested-by: Benjamin Franzke <ben@bnf.dev> Tested-by: Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by: Oliver Bartsch <bo@cedev.de> Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com> --- .../Resources/Private/Templates/SiteSettings/Overview.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/typo3/sysext/backend/Resources/Private/Templates/SiteSettings/Overview.html b/typo3/sysext/backend/Resources/Private/Templates/SiteSettings/Overview.html index 1c2f3abcba87..6e468b2884cd 100644 --- a/typo3/sysext/backend/Resources/Private/Templates/SiteSettings/Overview.html +++ b/typo3/sysext/backend/Resources/Private/Templates/SiteSettings/Overview.html @@ -23,7 +23,7 @@ </p> </details> - <f:if condition="{c.localSettings.allFlat->f:count()} > 0"> + <f:if condition="{c.localSettings.map->f:count()} > 0"> <details open name="details-{c.site.identifier}"> <summary><f:translate key="LLL:EXT:backend/Resources/Private/Language/locallang_sitesettings.xlf:overview.customSettingsSummary" arguments="{0: '{c.localSettings.map->f:count()}'}"/></summary> <p> -- GitLab