From 3bfba77a0b80369ce8e57935625d06b449c81037 Mon Sep 17 00:00:00 2001
From: Benni Mack <benni@typo3.org>
Date: Wed, 22 Nov 2017 23:44:52 +0100
Subject: [PATCH] [BUGFIX] Use correct runtime cache identifier for locked
records
The runtime cache was re-built wrong by using
a custom identifer, thus being called EVERY time a
record is checked. This puts the pagetree DB queries in half.
A simple check (like done previously with $GLOBALS['LOCKED_RECORDS'])
to a simple identifier solves this issue.
Related: #79345
Resolves: #83068
Releases: master, 8.7
Change-Id: Id422fbc81b145db3559c194774334692863b4699
Reviewed-on: https://review.typo3.org/54726
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
---
typo3/sysext/backend/Classes/Utility/BackendUtility.php | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/typo3/sysext/backend/Classes/Utility/BackendUtility.php b/typo3/sysext/backend/Classes/Utility/BackendUtility.php
index 6b1f3b4f51a2..a735cf62f1bf 100644
--- a/typo3/sysext/backend/Classes/Utility/BackendUtility.php
+++ b/typo3/sysext/backend/Classes/Utility/BackendUtility.php
@@ -3223,13 +3223,13 @@ class BackendUtility
*
* @param string $table Table name
* @param int $uid Record uid
- * @return array
+ * @return array|bool
* @internal
*/
public static function isRecordLocked($table, $uid)
{
$runtimeCache = self::getRuntimeCache();
- $cacheId = 'backend-recordLocked-' . md5($table . '_' . $uid);
+ $cacheId = 'backend-recordLocked';
$recordLockedCache = $runtimeCache->get($cacheId);
if ($recordLockedCache !== false) {
$lockedRecords = $recordLockedCache;
@@ -3300,7 +3300,7 @@ class BackendUtility
$runtimeCache->set($cacheId, $lockedRecords);
}
- return $lockedRecords[$table . ':' . $uid];
+ return $lockedRecords[$table . ':' . $uid] ?? false;
}
/**
--
GitLab