From 30139ac46428d3dbe03594e62698da3bfa3240ac Mon Sep 17 00:00:00 2001
From: Nicole Cordes <typo3@cordes.co>
Date: Mon, 5 Jun 2017 14:18:51 +0200
Subject: [PATCH] [BUGFIX] Prevent exception in ImageCropUpdater
The ImageCropUpdater throws an exception if a non-existing file is tried
to be processed. This happens because deleted rows are updated. The patch
checks the returned file object before further processing is executed.
Resolves: #81470
Releases: master, 8.7
Change-Id: I488994b1ad842e28d928f3b4a2db1c8c007afe3c
Reviewed-on: https://review.typo3.org/53120
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
---
.../install/Classes/Updates/RowUpdater/ImageCropUpdater.php | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/typo3/sysext/install/Classes/Updates/RowUpdater/ImageCropUpdater.php b/typo3/sysext/install/Classes/Updates/RowUpdater/ImageCropUpdater.php
index 1d99eed28ef0..8107a7cf5d70 100644
--- a/typo3/sysext/install/Classes/Updates/RowUpdater/ImageCropUpdater.php
+++ b/typo3/sysext/install/Classes/Updates/RowUpdater/ImageCropUpdater.php
@@ -76,9 +76,13 @@ class ImageCropUpdater implements RowUpdaterInterface
foreach ($tablePayload['fields'] as $field) {
if (strpos($inputRow[$field], '{"x":') === 0) {
- $file = $this->getFile($inputRow, $tablePayload['fileReferenceField'] ?: 'uid_local');
$cropArray = json_decode($inputRow[$field], true);
if (is_array($cropArray)) {
+ $file = $this->getFile($inputRow, $tablePayload['fileReferenceField'] ?: 'uid_local');
+ if (null === $file) {
+ continue;
+ }
+
$cropArea = Area::createFromConfiguration(json_decode($inputRow[$field], true));
$cropVariantCollectionConfig = [
'default' => [
--
GitLab