From 272e1445fc88fd2db0c57342b4393ebb8452da31 Mon Sep 17 00:00:00 2001
From: Markus Klein <markus.klein@typo3.org>
Date: Fri, 27 Mar 2020 13:59:28 +0100
Subject: [PATCH] [BUGFIX] Do not render a-tag if URL is empty in link.action
 VH
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

If the URL cannot be calculated by the UriBuilder an empty URL
is returned. In this case no a-tag is rendered to avoid links
with an empty href-attribute.

Resolves: #90857
Releases: master, 9.5, 8.7
Change-Id: I597a4b11d986a3b6155a695e6fd3c84a94588a1a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63953
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
---
 .../sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/typo3/sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php b/typo3/sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php
index d4c1f3bbaec0..730d491cf54f 100644
--- a/typo3/sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php
+++ b/typo3/sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php
@@ -120,6 +120,9 @@ class ActionViewHelper extends AbstractTagBasedViewHelper
         }
 
         $uri = $uriBuilder->uriFor($action, $parameters, $controller, $extensionName, $pluginName);
+        if ($uri === '') {
+            return $this->renderChildren();
+        }
         $this->tag->addAttribute('href', $uri);
         $this->tag->setContent($this->renderChildren());
         $this->tag->forceClosingTag(true);
-- 
GitLab