From 1f68f1ac3483bcf689cc49d073e41dffd96bcefa Mon Sep 17 00:00:00 2001
From: Christian Kuhn <lolli@schwarzbu.ch>
Date: Thu, 15 Feb 2024 17:38:28 +0100
Subject: [PATCH] [TASK] Remove unused DH $data_disableFields
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Similar to #103132. This time, public `@internal`
property $data_disableFields is only read, but
never written.
Reading the property comment, it looks as if this
may have been used as a detail scenario within
ext:impexp that has been removed long ago.
History reveals no core usage since ever: That
property hasn't even been used with Kaspers
initial commit in 2003.
Let's drop this artifact and keep it in versioning
museum forever.
Resolves: #103133
Related: #103132
Releases: main
Change-Id: I2bfddad06f2cbb2610fb55f67a9dda40d75ab7e8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83016
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Kienast <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Andreas Kienast <a.fernandez@scripting-base.de>
---
.../sysext/core/Classes/DataHandling/DataHandler.php | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/typo3/sysext/core/Classes/DataHandling/DataHandler.php b/typo3/sysext/core/Classes/DataHandling/DataHandler.php
index 317ee255486a..9707fbb66c57 100644
--- a/typo3/sysext/core/Classes/DataHandling/DataHandler.php
+++ b/typo3/sysext/core/Classes/DataHandling/DataHandler.php
@@ -213,16 +213,6 @@ class DataHandler implements LoggerAwareInterface
*/
public $overrideValues = [];
- /**
- * If entries are set in this array corresponding to fields for update, they are ignored and thus NOT updated.
- * You could set this array from a series of checkboxes with value=0 and hidden fields before the checkbox with 1.
- * Then an empty checkbox will disable the field.
- *
- * @var array
- * @internal should only be used from within TYPO3 Core
- */
- public $data_disableFields = [];
-
/**
* Use this array to validate suggested uids for tables by setting [table]:[uid]. This is a dangerous option
* since it will force the inserted record to have a certain UID. The value just have to be TRUE, but if you set
@@ -1278,7 +1268,7 @@ class DataHandler implements LoggerAwareInterface
// - If the field is nothing of the above and the field is configured in TCA, the fieldvalues are evaluated by ->checkValue
// If everything is OK, the field is entered into $fieldArray[]
foreach ($incomingFieldArray as $field => $fieldValue) {
- if (isset($this->excludedTablesAndFields[$table . '-' . $field]) || (bool)($this->data_disableFields[$table][$id][$field] ?? false)) {
+ if (isset($this->excludedTablesAndFields[$table . '-' . $field])) {
continue;
}
--
GitLab