From 1ec1de7c33fb137e44e0ac85785acaf8162469bb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Frank=20Na=CC=88gler?= <frank.naegler@typo3.org>
Date: Fri, 13 Nov 2015 16:45:35 +0100
Subject: [PATCH] [BUGFIX] Wrong overloading of AbstractController::redirect()
This patch add a todo for deprecation in CMS8 and remove the usage
of the wrong overloaded method in the core.
Resolves: #71303
Releases: master
Change-Id: Id42af6b16a382d67313e66e695096669e07d4959
Reviewed-on: https://review.typo3.org/44707
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Oliver Eglseder <oliver.eglseder@in2code.de>
Tested-by: Oliver Eglseder <oliver.eglseder@in2code.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
---
.../install/Classes/Controller/BackendModuleController.php | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/typo3/sysext/install/Classes/Controller/BackendModuleController.php b/typo3/sysext/install/Classes/Controller/BackendModuleController.php
index 72456d65491c..6f98be510867 100644
--- a/typo3/sysext/install/Classes/Controller/BackendModuleController.php
+++ b/typo3/sysext/install/Classes/Controller/BackendModuleController.php
@@ -59,7 +59,7 @@ class BackendModuleController extends \TYPO3\CMS\Extbase\Mvc\Controller\ActionCo
public function indexAction()
{
if ($this->enableFileService->checkInstallToolEnableFile()) {
- $this->redirect('sysext/install/Start/Install.php?install[context]=backend');
+ \TYPO3\CMS\Core\Utility\HttpUtility::redirect('sysext/install/Start/Install.php?install[context]=backend');
} else {
$this->forward('showEnableInstallToolButton');
}
@@ -95,6 +95,8 @@ class BackendModuleController extends \TYPO3\CMS\Extbase\Mvc\Controller\ActionCo
* Redirect to specified URI
*
* @param string $uri
+ * @todo: deprecate this method in CMS8, it overload the method of AbstractController in wrong way.
+ * @todo: to late to deprecate in CMS7
*/
protected function redirect($uri)
{
--
GitLab