From 1e26d0901d5206bd7983c7d1e3e312381a0ffda7 Mon Sep 17 00:00:00 2001
From: Markus Klein <markus.klein@typo3.org>
Date: Sun, 19 Nov 2017 02:34:46 +0100
Subject: [PATCH] [BUGFIX] ConstantEditor: Make boolean fields UI working in
Edge/IE
Move the hidden form field out of the label tag to ensure clicking
the label's content (eg. fa icon) really toggles the checkbox.
Resolves: #82998
Releases: master, 8.7, 7.6
Change-Id: Id4293b4109c82a9e6410e113a5b5560ffd1b75d4
Reviewed-on: https://review.typo3.org/54682
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
---
.../Classes/TypoScript/ExtendedTemplateService.php | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php b/typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php
index 5ea0f7072bcf..6f4818c834de 100644
--- a/typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php
+++ b/typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php
@@ -1198,17 +1198,17 @@ class ExtendedTemplateService extends TemplateService
case 'boolean':
$sel = $fV ? 'checked' : '';
$p_field =
- '<label class="btn btn-default btn-checkbox">'
- . '<input type="hidden" name="' . $fN . '" value="0" />'
- . '<input id="' . $idName . '" type="checkbox" name="' . $fN . '" value="' . ($typeDat['paramstr'] ? $typeDat['paramstr'] : 1) . '" ' . $sel . ' onClick="uFormUrl(' . $aname . ')" />'
- . '<span class="t3-icon fa"></span>'
+ '<input type="hidden" name="' . $fN . '" value="0" />'
+ . '<label class="btn btn-default btn-checkbox">'
+ . '<input id="' . $idName . '" type="checkbox" name="' . $fN . '" value="' . ($typeDat['paramstr'] ? $typeDat['paramstr'] : 1) . '" ' . $sel . ' onClick="uFormUrl(' . $aname . ')" />'
+ . '<span class="t3-icon fa"></span>'
. '</label>';
break;
case 'comment':
$sel = $fV ? 'checked' : '';
$p_field =
- '<label class="btn btn-default btn-checkbox">'
- . '<input type="hidden" name="' . $fN . '" value="#" />'
+ '<input type="hidden" name="' . $fN . '" value="#" />'
+ . '<label class="btn btn-default btn-checkbox">'
. '<input id="' . $idName . '" type="checkbox" name="' . $fN . '" value="" ' . $sel . ' onClick="uFormUrl(' . $aname . ')" />'
. '<span class="t3-icon fa"></span>'
. '</label>';
--
GitLab