From 17ab8082af9c233c1ca16f3c993fa2b9e4eb6440 Mon Sep 17 00:00:00 2001
From: Susanne Moog <look@susi.dev>
Date: Thu, 26 Mar 2020 09:40:18 +0100
Subject: [PATCH] [BUGFIX] Allow all child nodes in
ActionMenuItemGroupViewHelper
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
While it was with good intentions, restricting the allowed child nodes
of the view helper restricts developers / integrators too much in their
usage as valid cases of using loops or conditions do not work anymore.
These restrictions have been removed.
Resolves: #87179
Releases: master, 9.5
Change-Id: I36c87a69902eb84bbe551f79d959f1869673e459
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63927
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
---
.../ViewHelpers/Be/Menus/ActionMenuItemGroupViewHelper.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemGroupViewHelper.php b/typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemGroupViewHelper.php
index a431fe3ac668..aafc9797805b 100644
--- a/typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemGroupViewHelper.php
+++ b/typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemGroupViewHelper.php
@@ -65,7 +65,7 @@ class ActionMenuItemGroupViewHelper extends ActionMenuViewHelper
$this->tag->addAttribute('label', $label);
$options = '';
foreach ($this->childNodes as $childNode) {
- if ($childNode instanceof ViewHelperNode && $childNode->getViewHelperClassName() === ActionMenuItemViewHelper::class) {
+ if ($childNode instanceof ViewHelperNode) {
$options .= $childNode->evaluate($this->renderingContext);
}
}
--
GitLab