From 1741ee057d2621fcde35cf1fe7ef3fe69045a74a Mon Sep 17 00:00:00 2001
From: Alexander Schnitzler <git@alexanderschnitzler.de>
Date: Sat, 15 Feb 2020 13:31:38 +0100
Subject: [PATCH] [BUGFIX] Client exceptions must return request
Both the \TYPO3\CMS\Core\Http\Client\RequestException and
\TYPO3\CMS\Core\Http\Client\NetworkException declare a method
getRequest which must return a RequestInterface object which
they did not.
Releases: master
Resolves: #90379
Change-Id: I4cdee1cdf95efc1ebcabaacec7be2cd290f31989
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63254
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
---
typo3/sysext/core/Classes/Http/Client/NetworkException.php | 2 +-
typo3/sysext/core/Classes/Http/Client/RequestException.php | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/typo3/sysext/core/Classes/Http/Client/NetworkException.php b/typo3/sysext/core/Classes/Http/Client/NetworkException.php
index c84ccea1c12f..b3a593b590db 100644
--- a/typo3/sysext/core/Classes/Http/Client/NetworkException.php
+++ b/typo3/sysext/core/Classes/Http/Client/NetworkException.php
@@ -37,6 +37,6 @@ class NetworkException extends GuzzleConnectException implements NetworkExceptio
public function getRequest(): RequestInterface
{
- parent::getRequest();
+ return parent::getRequest();
}
}
diff --git a/typo3/sysext/core/Classes/Http/Client/RequestException.php b/typo3/sysext/core/Classes/Http/Client/RequestException.php
index fe794bd80087..20e524f56677 100644
--- a/typo3/sysext/core/Classes/Http/Client/RequestException.php
+++ b/typo3/sysext/core/Classes/Http/Client/RequestException.php
@@ -37,6 +37,6 @@ class RequestException extends GuzzleRequestException implements RequestExceptio
public function getRequest(): RequestInterface
{
- parent::getRequest();
+ return parent::getRequest();
}
}
--
GitLab